From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTP id E6F3743094
for <ffmpegdev@gitmailbox.com>; Fri, 20 May 2022 11:27:18 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 52C9468B462;
Fri, 20 May 2022 14:27:16 +0300 (EEST)
Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com
[209.85.218.54])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16EB668B3E3
for <ffmpeg-devel@ffmpeg.org>; Fri, 20 May 2022 14:27:10 +0300 (EEST)
Received: by mail-ej1-f54.google.com with SMTP id jx22so1580339ejb.12
for <ffmpeg-devel@ffmpeg.org>; Fri, 20 May 2022 04:27:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
bh=W43qcQuLVSqcILcTtNuVpD+aO49GQ4+Pf7S8vHmEdEM=;
b=Tf/X13d8LsvSKxnJvhFSrWVlaM0uQ3MzzabCHOUIK/8XU8rO31HzcokhsYplel+mJd
jfhpzGDAeoxIZ5UpB1B2z5JKcrAYkjb4ui7e5QgTGbtRnrBMRdCTAznv1F77zfsaIuCD
pD/obKMrzkn1XrNOb9UKb0qk0ThwSw+nwgQx3VqOzeIm4mGHE2aFJRhilSyFmUe8Xcir
sZUjK4e9P/S8CwFeH85CCquqiTTobn/IP0tQ3WZ6Etd5AmjICavegh/+WKBPp3G3dWzP
yweyWbcs/MuBMCAU8AFK7AVISvBQdSAYl4iy2KurKw5yPTsKeiyrOmEFarjyBzGB5UPQ
Q+jQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to;
bh=W43qcQuLVSqcILcTtNuVpD+aO49GQ4+Pf7S8vHmEdEM=;
b=Gzg6ruNKO3yewID0pdH3nlTwvzqeKEcuZmO5DuiSTTLow9cUO94RvpJTy3siGpKY3a
P/TCPCwiSQ9lsmyjEtJ5nHEOIU+Hk8JJsadHBUK67HGbejo/WWEwPy88voRNVFBQwzPc
oIQWUFzqmQyA2B88BWfvEehCdiSzyezgxehHLEaK9Syx3kovG4aHHz9NNwDssTq6OLPj
oqZ4Ww5d6YNFfKWeokIhO//6w3rEhRUl7XmY4dhA9hClpAXU+VxwiIKIQE6GaPfaDcK9
0C2kaQ/8jwz1YlVVAVIoyEIR3scZGclq5SIB+IitGelczbTJTkGhxTTFGGCKp98kjvo/
g8bQ==
X-Gm-Message-State: AOAM532J1brBTEEXXO5IU3fhjLxa/HQ4yFfgovA2y+Ap3cKQ/4tmgKQh
oJRCILuIxv90SvonozqVyLP4tIJPq0egHJSYPJml1sv8
X-Google-Smtp-Source: ABdhPJymH8UsJz1bakohWvvD6njxy/eQlbv7xnDJ5HzEEfYwXwkrOIaRKUiCongMr1eHzlEAXW6no/3gNbjj46ZaHL4=
X-Received: by 2002:a17:906:478b:b0:6f8:5850:4da9 with SMTP id
cw11-20020a170906478b00b006f858504da9mr8223437ejc.619.1653046028461; Fri, 20
May 2022 04:27:08 -0700 (PDT)
MIME-Version: 1.0
References: <20220518151817.21270-1-leo.izen@gmail.com>
<20220518182338.GR396728@pb2>
<20220518182748.GS396728@pb2> <20220520102815.GT396728@pb2>
In-Reply-To: <20220520102815.GT396728@pb2>
From: "Ronald S. Bultje" <rsbultje@gmail.com>
Date: Fri, 20 May 2022 07:26:56 -0400
Message-ID: <CAEEMt2=-HJ5n4aXWXyS9s5fz3V4SyNhp=DPBBfG_K2WsM2Fgzw@mail.gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for
colorspace structs
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/CAEEMt2=-HJ5n4aXWXyS9s5fz3V4SyNhp=DPBBfG_K2WsM2Fgzw@mail.gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
Hi Michael,
On Fri, May 20, 2022 at 6:28 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> 1. exactly representing values
>
This isn't actually what I meant when I made the argument. If the spec says
"0.137", I'd expect to be able to git grep the source code for "0.137" and
find where it's defined. This is lost with AVRational, where it becomes {
137, 1000 }. This may sound silly, but I find this helpful.
One way to address this is to add the exact value in a comment, like
"(AVRational) { 137, 1000 }, // 0.137". This isn't pretty but retains
grep-discoverability.
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".