From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs
Date: Fri, 20 May 2022 07:26:56 -0400
Message-ID: <CAEEMt2=-HJ5n4aXWXyS9s5fz3V4SyNhp=DPBBfG_K2WsM2Fgzw@mail.gmail.com> (raw)
In-Reply-To: <20220520102815.GT396728@pb2>
Hi Michael,
On Fri, May 20, 2022 at 6:28 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> 1. exactly representing values
>
This isn't actually what I meant when I made the argument. If the spec says
"0.137", I'd expect to be able to git grep the source code for "0.137" and
find where it's defined. This is lost with AVRational, where it becomes {
137, 1000 }. This may sound silly, but I find this helpful.
One way to address this is to add the exact value in a comment, like
"(AVRational) { 137, 1000 }, // 0.137". This isn't pretty but retains
grep-discoverability.
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-20 11:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 15:18 Leo Izen
2022-05-18 18:23 ` Michael Niedermayer
2022-05-18 18:27 ` Michael Niedermayer
2022-05-20 10:28 ` Michael Niedermayer
2022-05-20 11:26 ` Ronald S. Bultje [this message]
2022-05-20 13:11 ` Michael Niedermayer
2022-05-20 13:39 ` Ronald S. Bultje
2022-05-20 11:53 ` James Almer
2022-05-20 13:23 ` Michael Niedermayer
2022-05-20 15:50 ` Anton Khirnov
2022-05-20 16:02 ` Leo Izen
2022-05-20 16:33 ` Niklas Haas
2022-05-20 12:08 ` Leo Izen
2022-05-20 17:20 ` Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEEMt2=-HJ5n4aXWXyS9s5fz3V4SyNhp=DPBBfG_K2WsM2Fgzw@mail.gmail.com' \
--to=rsbultje@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git