From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/wavdec: fix the ID3 metadata obtained in WAV format's missing
Date: Tue, 23 Aug 2022 09:59:01 +0800
Message-ID: <CADxeRwndJZaYg-jYja8NsFGeznyMao+UHDaXhZqF7JmMk2Z2tA@mail.gmail.com> (raw)
In-Reply-To: <2353fb95968f447f88e22aaa17025b38@huawei.com>
Wujian(Chin) <wujian2@huawei.com> 于2022年8月22日周一 22:00写道：
>
> Fixes ticket #9848.
>
> Signed-off-by: wujian_nanjing <wujian2@huawei.com>
> ---
> libavformat/wavdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
> index ca61b84..e3f790f 100644
> --- a/libavformat/wavdec.c
> +++ b/libavformat/wavdec.c
> @@ -555,7 +555,7 @@ static int wav_read_header(AVFormatContext *s)
> case MKTAG('I', 'D', '3', ' '):
> case MKTAG('i', 'd', '3', ' '): {
> ID3v2ExtraMeta *id3v2_extra_meta;
> - ff_id3v2_read_dict(pb, &ffformatcontext(s)->id3v2_meta, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta);
> + ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC, &id3v2_extra_meta, 0);
> if (id3v2_extra_meta) {
> ff_id3v2_parse_apic(s, id3v2_extra_meta);
> ff_id3v2_parse_chapters(s, id3v2_extra_meta);
> --
> 2.7.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Tested ok to me, will push this patch after 24 hours if there have no
objections.
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-23 1:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 13:59 Wujian(Chin)
2022-08-23 1:59 ` Steven Liu [this message]
2022-08-24 2:46 ` Steven Liu
-- strict thread matches above, loose matches on Subject: below --
2022-08-20 10:23 [FFmpeg-devel] 答复: " Wujian(Chin)
2022-08-15 11:32 Wujian(Chin)
2022-08-09 12:02 [FFmpeg-devel] " Wujian(Chin)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADxeRwndJZaYg-jYja8NsFGeznyMao+UHDaXhZqF7JmMk2Z2tA@mail.gmail.com \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git