Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: nachiket.programmer@gmail.com
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: fix frag_index.current out of sync
Date: Thu, 11 Aug 2022 15:56:33 +0800
Message-ID: <CADxeRwnZnD0U=uCUApD5=CFA0YT=3R-iSENdeou-R8uEJh=Lhg@mail.gmail.com> (raw)
In-Reply-To: <tencent_AD131A684E73E2B369D5D989180EAE454F05@qq.com>

"zhilizhao(赵志立)" <quinkblack@foxmail.com> 于2022年8月11日周四 15:07写道:
>
>
>
> > On Jul 31, 2022, at 1:14 AM, Zhao Zhili <quinkblack@foxmail.com> wrote:
> >
> > From: Zhao Zhili <zhilizhao@tencent.com>
> >
> > frag_index.current is used by cenc_filter, and is updated inside
> > mov_read_moof. It can out of sync regarding to mov_read_packet.
> >
> > Partly fix ticket #9807.
> > ---
> > libavformat/mov.c | 27 ++++++++++++++++++++++++++-
> > 1 file changed, 26 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > index a09a762d91..ce12a9e4f1 100644
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -7095,6 +7095,31 @@ static int cenc_decrypt(MOVContext *c, MOVStreamContext *sc, AVEncryptionInfo *s
> >     }
> > }
>
>
> Ping for review.
>
looks ok to me.

> By the way, there is a fate failure on patchwork which is unlikely
> introduced by this patchset (It happened on another patch before).
> So how to make patchwork rerun the fate test without resending the
> patch again?
make again to test by fate :D
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-08-11  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30 17:14 Zhao Zhili
2022-07-31  0:26 ` Steven Liu
2022-08-11  7:06 ` "zhilizhao(赵志立)"
2022-08-11  7:56   ` Steven Liu [this message]
2022-08-16  3:34     ` "zhilizhao(赵志立)"

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADxeRwnZnD0U=uCUApD5=CFA0YT=3R-iSENdeou-R8uEJh=Lhg@mail.gmail.com' \
    --to=lingjiujianke@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=nachiket.programmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git