From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffplay: Fixed typo in frame_queue_destory
Date: Wed, 5 Jul 2023 11:39:33 +0800
Message-ID: <CADxeRwnYWU6oytKg41zQSRXGWkwcEXNvHZ0mFo7hytoZ=mKp6Q@mail.gmail.com> (raw)
In-Reply-To: <3169cf0a.5f9d.189241f3e9e.Coremail.liqitong@163.com>
QiTong Li <liqitong@163.com> 于2023年7月5日周三 11:36写道:
>
> Not sure if the function naming frame_queue_destory is intended because "destory" is not really a word. Changing it to "destroy" makes more sense.
>
> Signed-off-by: QiTong Li <liqitong@163.com>
> ---
> fftools/ffplay.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 663f61d8b2..51cde0d208 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -696,7 +696,7 @@ static int frame_queue_init(FrameQueue *f, PacketQueue *pktq, int max_size, int
> return 0;
> }
>
> -static void frame_queue_destory(FrameQueue *f)
> +static void frame_queue_destroy(FrameQueue *f)
> {
> int i;
> for (i = 0; i < f->max_size; i++) {
> @@ -1252,9 +1252,9 @@ static void stream_close(VideoState *is)
> packet_queue_destroy(&is->subtitleq);
>
> /* free all pictures */
> - frame_queue_destory(&is->pictq);
> - frame_queue_destory(&is->sampq);
> - frame_queue_destory(&is->subpq);
> + frame_queue_destroy(&is->pictq);
> + frame_queue_destroy(&is->sampq);
> + frame_queue_destroy(&is->subpq);
> SDL_DestroyCond(is->continue_read_thread);
> sws_freeContext(is->sub_convert_ctx);
> av_free(is->filename);
> --
> 2.33.0.windows.2
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
LGTM
Thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-05 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 3:36 QiTong Li
2023-07-05 3:39 ` Steven Liu [this message]
2023-07-06 19:23 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADxeRwnYWU6oytKg41zQSRXGWkwcEXNvHZ0mFo7hytoZ=mKp6Q@mail.gmail.com' \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git