From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Patchwork <yinshiyou-hf@loongson.cn>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: Check if the file descriptor is valid before closing
Date: Fri, 1 Jul 2022 09:59:42 +0800
Message-ID: <CADxeRwnVdZZtj5O4Qdu6-jKWFSVQ8HSyOdF3iP2hyd-qEV83-Q@mail.gmail.com> (raw)
In-Reply-To: <bbdc6e9eb43844aea1923c0cf1fbae4a@huawei.com>
Wujian(Chin) <wujian2@huawei.com> 于2022年6月28日周二 19:15写道:
>
> Fixes ticket #9507.
>
> Signed-off-by: wujian_nanjing <wujian2@huawei.com>
> ---
> libavcodec/v4l2_m2m.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c
> index 51932ba..9849360 100644
> --- a/libavcodec/v4l2_m2m.c
> +++ b/libavcodec/v4l2_m2m.c
> @@ -251,7 +251,8 @@ static void v4l2_m2m_destroy_context(void *opaque, uint8_t *context)
> ff_v4l2_context_release(&s->capture);
> sem_destroy(&s->refsync);
>
> - close(s->fd);
> + if (s->fd >= 0)
> + close(s->fd);
> av_frame_unref(s->frame);
> av_frame_free(&s->frame);
> av_packet_unref(&s->buf_pkt);
> --
> 2.7.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Applied
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-07-01 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 11:15 Wujian(Chin)
2022-07-01 1:59 ` Steven Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADxeRwnVdZZtj5O4Qdu6-jKWFSVQ8HSyOdF3iP2hyd-qEV83-Q@mail.gmail.com \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=yinshiyou-hf@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git