Re: [FFmpeg-devel] [PATCH 09/18] avformat/udp: don't override 0 localport

From: Steven Liu <lingjiujianke-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Timo Rothenpieler <timo@rothenpieler.org>
Subject: Re: [FFmpeg-devel] [PATCH 09/18] avformat/udp: don't override 0 localport
Date: Thu, 3 Jul 2025 22:05:01 +0800
Message-ID: <CADxeRwmwU3uzb+FCrQzdWnP0ZGgH=ByH60tKPuPBWWx8t_dnnQ@mail.gmail.com> (raw)
In-Reply-To: <20250702165655.1325-10-timo@rothenpieler.org>

Timo Rothenpieler <timo@rothenpieler.org> 于2025年7月3日周四 01:09写道：
>
> ---
>  libavformat/udp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/udp.c b/libavformat/udp.c
> index c1ebdd1222..30f075de8e 100644
> --- a/libavformat/udp.c
> +++ b/libavformat/udp.c
> @@ -780,7 +780,7 @@ static int udp_open(URLContext *h, const char *uri, int flags)
>              goto fail;
>      }
>
> -    if ((s->is_multicast || s->local_port <= 0) && (h->flags & AVIO_FLAG_READ))
> +    if ((s->is_multicast || s->local_port < 0) && (h->flags & AVIO_FLAG_READ))
>          s->local_port = port;
>
>      udp_fd = udp_socket_create(h, &my_addr, &len, s->localaddr);
> --
> 2.49.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

LGTM

Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".