Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Cai Fan <caifan0425@163.com>
Subject: Re: [FFmpeg-devel]  [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
Date: Tue, 29 Jul 2025 17:40:46 +0800
Message-ID: <CADxeRwmv7iwSB=nJB+nJTT0jVT1XFekcdfC2x9A7KMCapZinkw@mail.gmail.com> (raw)
In-Reply-To: <20250729022312.2157485-1-caifan0425@163.com>

Cai Fan <caifan0425@163.com> 于2025年7月29日周二 10:23写道:
>
> Signed-off-by: Cai Fan <caifan0425@163.com>
> ---
>  libavformat/img2enc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
> index 672cfe18fd..f7d983ec54 100644
> --- a/libavformat/img2enc.c
> +++ b/libavformat/img2enc.c
> @@ -182,7 +182,8 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
>          av_dict_copy(&options, img->protocol_opts, 0);
>          if (strlen(filename) + 5 >= sizeof(img->tmp[i])) {
>              av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename);
> -            return AVERROR(EINVAL);
> +            ret = AVERROR(EINVAL);
> +            goto fail;

perhaps you should make patch base on the ffmpeg git master, don't
base on yourseves newest commit.

>          }
>          snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
>          av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-07-29  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  2:23 Cai Fan
2025-07-29  9:40 ` Steven Liu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-28  3:45 Cai Fan
2025-07-28  9:51 ` Steven Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADxeRwmv7iwSB=nJB+nJTT0jVT1XFekcdfC2x9A7KMCapZinkw@mail.gmail.com' \
    --to=lingjiujianke@gmail.com \
    --cc=caifan0425@163.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git