From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/mediacodecenc: make each encoder has its own option
Date: Mon, 5 Dec 2022 12:23:45 +0800
Message-ID: <CADxeRwmrrM=k7QQ7MM12CNoK5H62BsCCtKYyQu04BRbscHyMCg@mail.gmail.com> (raw)
In-Reply-To: <tencent_BB49731B885693EDF36175D12915EEA24505@qq.com>
Zhao Zhili <quinkblack@foxmail.com> 于2022年12月5日周一 01:13写道：
>
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> libavcodec/mediacodecenc.c | 42 ++++++++++++++++++++++----------------
> 1 file changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c
> index c8d8f84e46..c28cce56c6 100644
> --- a/libavcodec/mediacodecenc.c
> +++ b/libavcodec/mediacodecenc.c
> @@ -495,29 +495,27 @@ static const AVCodecHWConfigInternal *const mediacodec_hw_configs[] = {
>
> #define OFFSET(x) offsetof(MediaCodecEncContext, x)
> #define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
> -static const AVOption common_options[] = {
> - { "ndk_codec", "Use MediaCodec from NDK",
> - OFFSET(use_ndk_codec), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE },
> - { "codec_name", "Select codec by name",
> - OFFSET(name), AV_OPT_TYPE_STRING, {0}, 0, 0, VE },
> - { "bitrate_mode", "Bitrate control method",
> - OFFSET(bitrate_mode), AV_OPT_TYPE_INT, {.i64 = -1}, -1, INT_MAX, VE, "bitrate_mode" },
> - { "cq", "Constant quality mode",
> - 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_CQ}, 0, 0, VE, "bitrate_mode" },
> - { "vbr", "Variable bitrate mode",
> - 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_VBR}, 0, 0, VE, "bitrate_mode" },
> - { "cbr", "Constant bitrate mode",
> - 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_CBR}, 0, 0, VE, "bitrate_mode" },
> - { "cbr_fd", "Constant bitrate mode with frame drops",
> - 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_CBR_FD}, 0, 0, VE, "bitrate_mode" },
> - { NULL },
> -};
> +#define COMMON_OPTION \
> + { "ndk_codec", "Use MediaCodec from NDK", \
> + OFFSET(use_ndk_codec), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE }, \
> + { "codec_name", "Select codec by name", \
> + OFFSET(name), AV_OPT_TYPE_STRING, {0}, 0, 0, VE }, \
> + { "bitrate_mode", "Bitrate control method", \
> + OFFSET(bitrate_mode), AV_OPT_TYPE_INT, {.i64 = -1}, -1, INT_MAX, VE, "bitrate_mode" }, \
> + { "cq", "Constant quality mode", \
> + 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_CQ}, 0, 0, VE, "bitrate_mode" }, \
> + { "vbr", "Variable bitrate mode", \
> + 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_VBR}, 0, 0, VE, "bitrate_mode" }, \
> + { "cbr", "Constant bitrate mode", \
> + 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_CBR}, 0, 0, VE, "bitrate_mode" }, \
> + { "cbr_fd", "Constant bitrate mode with frame drops", \
> + 0, AV_OPT_TYPE_CONST, {.i64 = BITRATE_MODE_CBR_FD}, 0, 0, VE, "bitrate_mode" }, \
Why don't merge 1/7 and 2/7 into one step?
>
> #define MEDIACODEC_ENCODER_CLASS(name) \
> static const AVClass name ## _mediacodec_class = { \
> .class_name = #name "_mediacodec", \
> .item_name = av_default_item_name, \
> - .option = common_options, \
> + .option = name ## _options, \
> .version = LIBAVUTIL_VERSION_INT, \
> }; \
>
> @@ -542,9 +540,17 @@ const FFCodec ff_ ## short_name ## _mediacodec_encoder = { \
> }; \
>
> #if CONFIG_H264_MEDIACODEC_ENCODER
> +static const AVOption h264_options[] = {
> + COMMON_OPTION
> + { NULL, }
> +};
> DECLARE_MEDIACODEC_ENCODER(h264, "H.264", AV_CODEC_ID_H264)
> #endif
>
> #if CONFIG_HEVC_MEDIACODEC_ENCODER
> +static const AVOption hevc_options[] = {
> + COMMON_OPTION
> + { NULL, }
> +};
> DECLARE_MEDIACODEC_ENCODER(hevc, "H.265", AV_CODEC_ID_HEVC)
> #endif
> --
> 2.25.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-05 4:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221204171228.50160-1-quinkblack@foxmail.com>
2022-12-04 17:12 ` Zhao Zhili
2022-12-05 4:23 ` Steven Liu [this message]
2022-12-05 5:29 ` [FFmpeg-devel] [Internet]Re: " "zhilizhao(赵志立)"
2022-12-04 17:12 ` [FFmpeg-devel] [PATCH 3/7] avcodec/mediacodecenc: add level option Zhao Zhili
2022-12-04 17:12 ` [FFmpeg-devel] [PATCH 4/7] avcodec/mediacodecenc: use bsf to handle crop Zhao Zhili
2022-12-04 17:12 ` [FFmpeg-devel] [PATCH 5/7] avcodec/mediacodecenc: remove the strategy to create DTS Zhao Zhili
2022-12-04 17:12 ` [FFmpeg-devel] [PATCH 6/7] avcodec/mediacodecenc: add max-bframes support Zhao Zhili
2022-12-04 17:12 ` [FFmpeg-devel] [PATCH 7/7] avcodec/mediacodecenc: add pts_as_dts option Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADxeRwmrrM=k7QQ7MM12CNoK5H62BsCCtKYyQu04BRbscHyMCg@mail.gmail.com' \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git