From: Steven Liu <lingjiujianke@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known Date: Sun, 8 Oct 2023 20:45:11 +0800 Message-ID: <CADxeRwmT6WfsBbBATM9=Nr30Ed4cb=8Lp1wfLYm=fNMPSU6ftg@mail.gmail.com> (raw) In-Reply-To: <52191ea3-cea6-4f23-82b0-4c5c99573fd2@gmail.com> James Almer <jamrial@gmail.com>于2023年10月8日 周日20:08写道: > On 10/8/2023 8:57 AM, Steven Liu wrote: > > Makes the output of the libaom av1 decoder consistent with external > decoders like > > libdav1d. > > > > reference commit: 1652f2492f88434010053289d946dab6a57e4d58 > > But it is known at this point. picture->sample_aspect_ratio is set > directly above. > > What needs to be done is initializing the decoder in aom_init() using > the extradata, so lavf will not attempt to decode frames in order to get > stream info, which is what i assume is happening here and why you want > SAR to be 0/1. i want fate pass > > > > > > Signed-off-by: Steven Liu <lq@chinaffmpeg.org> > > --- > > libavcodec/libaomdec.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c > > index 695d901051..ff4137bfc6 100644 > > --- a/libavcodec/libaomdec.c > > +++ b/libavcodec/libaomdec.c > > @@ -204,7 +204,6 @@ static int aom_decode(AVCodecContext *avctx, AVFrame > *picture, > > picture->height * img->r_w, > > picture->width * img->r_h, > > INT_MAX); > > - ff_set_sar(avctx, picture->sample_aspect_ratio); > > > > if ((img->fmt & AOM_IMG_FMT_HIGHBITDEPTH) && img->bit_depth == > 8) > > ff_aom_image_copy_16_to_8(picture, img); > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-08 12:45 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-08 11:57 Steven Liu 2023-10-08 12:09 ` James Almer 2023-10-08 12:45 ` Steven Liu [this message] 2023-10-08 12:49 ` James Almer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADxeRwmT6WfsBbBATM9=Nr30Ed4cb=8Lp1wfLYm=fNMPSU6ftg@mail.gmail.com' \ --to=lingjiujianke@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git