Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Remove dead ret stores
Date: Sat, 25 May 2024 20:41:08 +0800
Message-ID: <CADxeRwmJ3s9P-a_6MMc1S-yt63bBBaOad+xbsntA_z4XiVfGcg@mail.gmail.com> (raw)
In-Reply-To: <20240525111814.2587729-3-michael@niedermayer.cc>

Michael Niedermayer <michael@niedermayer.cc> 于2024年5月25日周六 19:18写道:

>
> Fixes: CID1529222 Unused value
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/hlsenc.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 0e2843c6bc5..8a43ef6232a 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -1582,8 +1582,6 @@ static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
>      ret = hlsenc_io_open(s, byterange_mode ? &hls->m3u8_out : &vs->out, temp_filename, &options);
>      av_dict_free(&options);
>      if (ret < 0) {
> -        if (hls->ignore_io_errors)
> -            ret = 0;
>          goto fail;
>      }
>
> @@ -1641,8 +1639,6 @@ static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
>          ret = hlsenc_io_open(s, &hls->sub_m3u8_out, temp_vtt_filename, &options);
>          av_dict_free(&options);
>          if (ret < 0) {
> -            if (hls->ignore_io_errors)
> -                ret = 0;
>              goto fail;
>          }
>          ff_hls_write_playlist_header(hls->sub_m3u8_out, hls->version, hls->allowcache,
> --
> 2.45.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

LGTM

Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-05-25 12:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-25 11:18 [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure Michael Niedermayer
2024-05-25 11:18 ` [FFmpeg-devel] [PATCH 2/3] avformat/fwse: Remove always false expression Michael Niedermayer
2024-06-02 19:04   ` Michael Niedermayer
2024-05-25 11:18 ` [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Remove dead ret stores Michael Niedermayer
2024-05-25 12:41   ` Steven Liu [this message]
2024-05-25 11:38 ` [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure Rémi Denis-Courmont
2024-05-25 12:19   ` Michael Niedermayer
2024-05-25 12:36     ` Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADxeRwmJ3s9P-a_6MMc1S-yt63bBBaOad+xbsntA_z4XiVfGcg@mail.gmail.com \
    --to=lingjiujianke@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git