Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH v1] avformat/hlsenc: Add resend_headers option
@ 2022-06-27 13:30 huheng
  2022-06-29  4:18 ` Steven Liu
  0 siblings, 1 reply; 2+ messages in thread
From: huheng @ 2022-06-27 13:30 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: huheng, lingjiujianke

Add pat and pmt table at start of each segment in single_file mode enhanced
compatibility of hls stream. Because some hls clients separate parsing segment
of hls stream, the absence of pat/pmt will cause parsing to fail.

Signed-off-by: huheng <heng.hu.1989@gmail.com>
---
 libavformat/hlsenc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 3bafddfa61..d18178e727 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -2631,6 +2631,9 @@ static int hls_write_packet(AVFormatContext *s, AVPacket *pkt)
             vs->start_pos += vs->size;
             if (hls->key_info_file || hls->encrypt)
                 ret = hls_start(s, vs);
+            if (hls->segment_type == SEGMENT_TYPE_MPEGTS && oc->oformat->priv_class && oc->priv_data) {
+                av_opt_set(oc->priv_data, "mpegts_flags", "resend_headers", 0);
+            }
         } else if (hls->max_seg_size > 0) {
             if (vs->size + vs->start_pos >= hls->max_seg_size) {
                 vs->sequence++;
-- 
2.36.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH v1] avformat/hlsenc: Add resend_headers option
  2022-06-27 13:30 [FFmpeg-devel] [PATCH v1] avformat/hlsenc: Add resend_headers option huheng
@ 2022-06-29  4:18 ` Steven Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Liu @ 2022-06-29  4:18 UTC (permalink / raw)
  To: huheng; +Cc: ffmpeg-devel

huheng <heng.hu.1989@gmail.com> 于2022年6月27日周一 21:30写道:
>
> Add pat and pmt table at start of each segment in single_file mode enhanced
> compatibility of hls stream. Because some hls clients separate parsing segment
> of hls stream, the absence of pat/pmt will cause parsing to fail.
>
> Signed-off-by: huheng <heng.hu.1989@gmail.com>
> ---
>  libavformat/hlsenc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 3bafddfa61..d18178e727 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -2631,6 +2631,9 @@ static int hls_write_packet(AVFormatContext *s, AVPacket *pkt)
>              vs->start_pos += vs->size;
>              if (hls->key_info_file || hls->encrypt)
>                  ret = hls_start(s, vs);
> +            if (hls->segment_type == SEGMENT_TYPE_MPEGTS && oc->oformat->priv_class && oc->priv_data) {
> +                av_opt_set(oc->priv_data, "mpegts_flags", "resend_headers", 0);
> +            }
>          } else if (hls->max_seg_size > 0) {
>              if (vs->size + vs->start_pos >= hls->max_seg_size) {
>                  vs->sequence++;
> --
> 2.36.1
>

LGTM
Will apply soon


Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-29  4:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 13:30 [FFmpeg-devel] [PATCH v1] avformat/hlsenc: Add resend_headers option huheng
2022-06-29  4:18 ` Steven Liu

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git