Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avformat/flv: correct the video frametype mask to 0x70
@ 2023-07-26  8:27 Steven Liu
  2023-08-14  6:18 ` Steven Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Liu @ 2023-07-26  8:27 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Steven Liu, flvAnalyser

avformat/flv: correct the video frametype mask to 0x70

because the flv specification said the video frametype
should use value range from 0x00 to 0x70,
so use 0xF0 have no problem before support enhanced flv,
but the 0xF0 will get incorrect result after support enhanced flv,
so should set the video frametype mask 0x70 to make it correct now.

Reported-By: flvAnalyser <hybase@qq.com>
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavformat/flv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/flv.h b/libavformat/flv.h
index 91e0a4140c..f710963b92 100644
--- a/libavformat/flv.h
+++ b/libavformat/flv.h
@@ -48,7 +48,7 @@
 #define FLV_AUDIO_CODECID_MASK    0xf0
 
 #define FLV_VIDEO_CODECID_MASK    0x0f
-#define FLV_VIDEO_FRAMETYPE_MASK  0xf0
+#define FLV_VIDEO_FRAMETYPE_MASK  0x70
 
 #define AMF_END_OF_OBJECT         0x09
 
-- 
2.40.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avformat/flv: correct the video frametype mask to 0x70
  2023-07-26  8:27 [FFmpeg-devel] [PATCH] avformat/flv: correct the video frametype mask to 0x70 Steven Liu
@ 2023-08-14  6:18 ` Steven Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Liu @ 2023-08-14  6:18 UTC (permalink / raw)
  To: FFmpeg development discussions and patches; +Cc: Steven Liu, flvAnalyser

Steven Liu <lq@chinaffmpeg.org> 于2023年7月26日周三 16:27写道:
>
> avformat/flv: correct the video frametype mask to 0x70
>
> because the flv specification said the video frametype
> should use value range from 0x00 to 0x70,
> so use 0xF0 have no problem before support enhanced flv,
> but the 0xF0 will get incorrect result after support enhanced flv,
> so should set the video frametype mask 0x70 to make it correct now.
>
> Reported-By: flvAnalyser <hybase@qq.com>
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  libavformat/flv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/flv.h b/libavformat/flv.h
> index 91e0a4140c..f710963b92 100644
> --- a/libavformat/flv.h
> +++ b/libavformat/flv.h
> @@ -48,7 +48,7 @@
>  #define FLV_AUDIO_CODECID_MASK    0xf0
>
>  #define FLV_VIDEO_CODECID_MASK    0x0f
> -#define FLV_VIDEO_FRAMETYPE_MASK  0xf0
> +#define FLV_VIDEO_FRAMETYPE_MASK  0x70
>
>  #define AMF_END_OF_OBJECT         0x09
>
> --
> 2.40.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

pushed


Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-14  6:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26  8:27 [FFmpeg-devel] [PATCH] avformat/flv: correct the video frametype mask to 0x70 Steven Liu
2023-08-14  6:18 ` Steven Liu

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git