From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Steven Liu <lq@chinaffmpeg.org>, flvAnalyser <hybase@qq.com>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/flv: correct the video frametype mask to 0x70
Date: Mon, 14 Aug 2023 14:18:14 +0800
Message-ID: <CADxeRwkFvokmPx1+wcTB1KixsVz1a+oeFTsu3yMtwNzEpDA3ig@mail.gmail.com> (raw)
In-Reply-To: <20230726082711.92361-1-lq@chinaffmpeg.org>
Steven Liu <lq@chinaffmpeg.org> 于2023年7月26日周三 16:27写道：
>
> avformat/flv: correct the video frametype mask to 0x70
>
> because the flv specification said the video frametype
> should use value range from 0x00 to 0x70,
> so use 0xF0 have no problem before support enhanced flv,
> but the 0xF0 will get incorrect result after support enhanced flv,
> so should set the video frametype mask 0x70 to make it correct now.
>
> Reported-By: flvAnalyser <hybase@qq.com>
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
> libavformat/flv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/flv.h b/libavformat/flv.h
> index 91e0a4140c..f710963b92 100644
> --- a/libavformat/flv.h
> +++ b/libavformat/flv.h
> @@ -48,7 +48,7 @@
> #define FLV_AUDIO_CODECID_MASK 0xf0
>
> #define FLV_VIDEO_CODECID_MASK 0x0f
> -#define FLV_VIDEO_FRAMETYPE_MASK 0xf0
> +#define FLV_VIDEO_FRAMETYPE_MASK 0x70
>
> #define AMF_END_OF_OBJECT 0x09
>
> --
> 2.40.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
pushed
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-08-14 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 8:27 Steven Liu
2023-08-14 6:18 ` Steven Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADxeRwkFvokmPx1+wcTB1KixsVz1a+oeFTsu3yMtwNzEpDA3ig@mail.gmail.com \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=hybase@qq.com \
--cc=lq@chinaffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git