Re: [FFmpeg-devel] [PATCH v1 1/3] tests/fate/flvenc: add hevc in enhanced flv test case

From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v1 1/3] tests/fate/flvenc: add hevc in enhanced flv test case
Date: Wed, 19 Jul 2023 17:11:49 +0800
Message-ID: <CADxeRwkBymWhneN9_17iOOd83Az9DWyAyDuyArZag81uhOxYEw@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB074476AA5BBB4D1EEF1AEED88F38A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt <andreas.rheinhardt@outlook.com> 于2023年7月18日周二 19:35写道：
>
> Steven Liu:
> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > ---
> >  tests/fate/flvenc.mak            | 11 +++++++++++
> >  tests/ref/fate/enhanced-flv-hevc |  6 ++++++
> >  2 files changed, 17 insertions(+)
> >  create mode 100644 tests/ref/fate/enhanced-flv-hevc
> >
> > diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak
> > index 5032fface3..a0af45e1a8 100644
> > --- a/tests/fate/flvenc.mak
> > +++ b/tests/fate/flvenc.mak
> > @@ -1,5 +1,16 @@
> >  FATE_FLVENC_FFMPEG_FFPROBE-$(call TRANSCODE, FLV, FLV, RAWVIDEO_DECODER SCALE_FILTER TESTSRC_FILTER LAVFI_INDEV) += fate-flv-add_keyframe_index
> >  fate-flv-add_keyframe_index: CMD = transcode "lavfi -graph testsrc=r=7:n=2:d=20" "foo" flv "-vf scale -c:v flv1 -dct int -g 7 -flvflags add_keyframe_index" "-c copy -t 0.1" "-show_entries format_tags"
> >
> > +
> > +tests/data/enhanced_flv_hevc.flv: TAG = GEN
> > +tests/data/enhanced_flv_hevc.flv: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
> > +     $(M)$(TARGET_EXEC) $(TARGET_PATH)/$< -nostdin \
> > +                     -f lavfi -i "testsrc=s=176x144:r=1:n=1:d=0.04" -pix_fmt yuv420p -c:v libx265 -bf 0 -threads 1 -t 0.04 -y $(TARGET_PATH)/tests/data/enhanced_flv_hevc.flv 2>/dev/null
> > +
>
> This will encode using libx265 which is beyond our control (and has
> issues with Valgrind). This would only work if the codec were lossless;
> but your command line isn't.
>
> Anyway, you should instead just use any of our hevc samples and remux it
> to flv and read the resulting file. There are lots of examples of how to
> do this that also avoid keeping the intermediate file around.
>
> The other two patches have the same issues.

Thanks Nicolas, i have modified the patchset try to use the samples
now, and resumit patchset :
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=9350

Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".