From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec
Date: Sat, 29 Jul 2023 18:06:20 +0800
Message-ID: <CADxeRwk4Q0STe=xUxstRN4EpAQZwzSqvEVo9uu9TsSkMmYiuJQ@mail.gmail.com> (raw)
In-Reply-To: <cc946e24-aeaf-af2d-2e6c-c6cf84bde9@passwd.hu>
Marton Balint <cus@passwd.hu>于2023年7月29日 周六16:45写道：
>
>
> On Sat, 29 Jul 2023, Hendrik Leppkes wrote:
>
> > On Sat, Jul 29, 2023 at 2:26 AM Steven Liu <lq@chinaffmpeg.org> wrote:
> >>
> >> read fourcc for video codec after VideoTagHeader read.
> >> passed as parameter to flv_same_video_codec.
> >>
> >
> > Add the same parameter to flv_set_video_codec, and then you can remove
> > the entire backwards seek and just read it and adjust the size like
> > all other parameters.
>
> As far as I see flv_set_video_codec should not read a binary fourcc in the
> first place when it is called from amf_parse_object.
yes i looked in flv_set_video_codec, it should not do the same operation,
because it cannot read codeid in exheader mode.
>
>
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-29 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 2:37 [FFmpeg-devel] [PATCH] avformat/flvdec: use avio operation instead of pb->buf_ptr use Steven Liu
2023-07-27 6:46 ` Hendrik Leppkes
2023-07-27 7:31 ` [FFmpeg-devel] [PATCH v2] " Steven Liu
2023-07-27 18:56 ` Marton Balint
2023-07-29 0:25 ` [FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec Steven Liu
2023-07-29 8:41 ` Hendrik Leppkes
2023-07-29 8:42 ` Marton Balint
2023-07-29 9:54 ` Hendrik Leppkes
2023-07-29 9:56 ` Hendrik Leppkes
2023-07-29 10:06 ` Steven Liu [this message]
2023-07-29 17:49 ` [FFmpeg-devel] [PATCH] avformat/flvdec: handle exheader fourcc correctly in metadata Marton Balint
2023-08-02 1:44 ` Steven Liu
2023-08-03 20:11 ` Marton Balint
2023-07-27 8:00 ` [FFmpeg-devel] [PATCH] avformat/flvdec: use avio operation instead of pb->buf_ptr use Steven Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADxeRwk4Q0STe=xUxstRN4EpAQZwzSqvEVo9uu9TsSkMmYiuJQ@mail.gmail.com' \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git