From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Steven Liu <lq@chinaffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 3/5] hlsenc: Remove bogus check for if (vs->start_pos) for appending segments
Date: Wed, 3 Jul 2024 09:19:30 +0800
Message-ID: <CADxeRw=sgJpySJXRDZLjPx=ckgUaX99QTFDZDJ-QU60Lau9Puw@mail.gmail.com> (raw)
In-Reply-To: <b236489e-5a0-c81a-d051-dd1372821bf8@martin.st>
Martin Storsjö <martin@martin.st> 于2024年7月3日周三 04:46写道：
>
> On Wed, 26 Jun 2024, Martin Storsjö wrote:
>
> > Previously, vs->start_pos was never 0 here, unless using the
> > -hls_segment_size option, which wasn't allowed for SEGMENT_TYPE_FMP4.
> > Therefore, this if statement was practically always taken anyway.
> >
> > Remove this bogus if statement, to allow changing vs->start_pos
> > to reflect the right value when not using the -hls_segment_size
> > option.
> > ---
> > libavformat/hlsenc.c | 17 ++++++++---------
> > 1 file changed, 8 insertions(+), 9 deletions(-)
>
> Ping Steven, is the second version of this patchset ok? The main
> difference is this patch, which is new.
LGTM
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-03 1:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 10:57 [FFmpeg-devel] [PATCH v2 1/5] hlsenc: Fix the return value accumulation in append_single_file Martin Storsjö
2024-06-26 10:57 ` [FFmpeg-devel] [PATCH v2 2/5] hlsenc: Fix setting vs->start_pos when not using HLS_SINGLE_FILE or hls_segment_size Martin Storsjö
2024-06-26 10:57 ` [FFmpeg-devel] [PATCH v2 3/5] hlsenc: Remove bogus check for if (vs->start_pos) for appending segments Martin Storsjö
2024-07-02 20:46 ` Martin Storsjö
2024-07-03 1:19 ` Steven Liu [this message]
2024-07-04 20:36 ` Martin Storsjö
2024-06-26 10:57 ` [FFmpeg-devel] [PATCH v2 4/5] hlsenc: When not using HLS_SINGLE_FILE, set vs->size to range_length Martin Storsjö
2024-06-26 10:57 ` [FFmpeg-devel] [PATCH v2 5/5] hlsenc: Calculate the average and actual maximum bitrate of segments Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADxeRw=sgJpySJXRDZLjPx=ckgUaX99QTFDZDJ-QU60Lau9Puw@mail.gmail.com' \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=lq@chinaffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git