From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AA84F43BB8 for ; Wed, 21 Sep 2022 06:03:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A6DF68BB37; Wed, 21 Sep 2022 09:03:54 +0300 (EEST) Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 94C4968BB1A for ; Wed, 21 Sep 2022 09:03:47 +0300 (EEST) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-127dca21a7dso7558186fac.12 for ; Tue, 20 Sep 2022 23:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=JS0zn7lhch6CK5b1mEIet45ty4s92+qm0/COewAQV2o=; b=SLASdBpnJk6fH82A4050jqGOY/XRMaNkS3QIQkVjSY15kIS+cxa0L1Z+fm/5ia6P9P SsA7IYLvZQE/H2oEJq+lB5fpGO9fXl2BXpV6ou9ZcN+RFZSH+2WGsghi1z1kf6w9xSK4 +TntxYnS/G4wS5Gb8V3vTI5RJ6s9qT48dGirJ69Rs+twDwZ0DezxneVbsDOZf8+v050H S5vOXHRLg/A4De6KAYC9H0cc+DJA9YYRQBw6FZxNvl7UC4fSaNlHx/ZB279R3pZsdpKQ YdUCdGCbAPwUVoT9xDXJlbJLsQdmx76R84QlUMeOfYlWEJVuLSPvoOBKBH5zlg9sj4Zh wg/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=JS0zn7lhch6CK5b1mEIet45ty4s92+qm0/COewAQV2o=; b=jUjihtWzInEgFsdtATx2v8XDtNSDivlTLVNsnpIcIHdab2dF6k5TiBoLz4BKB03PXa cSzAsHtz0f40IqZMk2zyZpy2Kj20R6ZYSD9HcX/WQXgPsmQH3cownorASELoyxMZYwHg kh0lrSOZZL86yBtR9SAS5E72i0FEwMKvBYcwswgbMnaRKXTHa19TILJ9lAPGSYvt0orO pgN03gZW9+FYbO/f2DIM/05tdd+lacGEmFWs+lzRNnWi+2dFl1J0rWI8puteKqpfO3gu l1Tipg4hf0scvth/RKPlGAKrdskyvmR0SzpxuZqeRm+R3fUvzGD50P8j4f+cWHWyW8WA jMOA== X-Gm-Message-State: ACrzQf3GYdITjl62D/ZVirzI0VI83/ucbMqCDV4UB7WFCJCXBtZHzkEC dmKB5J+3JGX66klLBb2zsi+4l93JO+vSmFvHGtSIQAXADc9/eA== X-Google-Smtp-Source: AMsMyM5nF2aeMIADKdA1xQmwnW6iuIeHVttmHoJgsi6y7dkUOblRP8m2fa+JaTscYULUkdjzPkVqVyTDw7Wnky9Pb1U= X-Received: by 2002:a05:6870:73d0:b0:127:d63b:a045 with SMTP id a16-20020a05687073d000b00127d63ba045mr4166630oan.189.1663740225332; Tue, 20 Sep 2022 23:03:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Steven Liu Date: Wed, 21 Sep 2022 14:03:34 +0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Fix crash on invalid input/ENOMEM, fix leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: QW5kcmVhcyBSaGVpbmhhcmR0IDxhbmRyZWFzLnJoZWluaGFyZHRAb3V0bG9vay5jb20+IOS6jjIw MjLlubQ55pyIMjHml6XlkajkuIkgMDQ6MjXlhpnpgZPvvJoKPgo+IEluIGNhc2UgYSBTdXBwbGVt ZW50YWxQcm9wZXJ0eSBub2RlIGV4aXN0cyBpbiBhbiBhZGFwdGF0aW9uc2V0LAo+IGl0IGlzIHNl YXJjaGVkIGZvciBhICJzY2hlbWVJZFVyaSIgcHJvcGVydHkgdmlhIHhtbEdldFByb3AoKS4KPiBX aGF0ZXZlciB4bWxHZXRQcm9wKCkgcmV0dXJucyBpcyB0aGVuIGNvbXBhcmVkIHZpYSBhdl9zdHJj YXNlY21wKCkKPiB0byBhIHN0cmluZyBsaXRlcmFsLiB4bWxHZXRQcm9wKCkgY2FuIHJldHVybiBO VUxMLCBuYW1lbHkgaW4gY2FzZQo+IG5vICJzY2hlbWVJZFVyaSIgZXhpc3RzIGFuZCAoZ2l2ZW4g dGhhdCB0aGlzIHN0cmluZyBpcyBhbGxvY2F0ZWQpCj4gcHJlc3VtYWJseSBhbHNvIG9uIGFsbG9j YXRpb24gZmFpbHVyZS4gTm8gY2hlY2sgZm9yIE5VTEwgaXMgZG9uZSwKPiBzbyB0aGlzIG1heSBj cmFzaC4KPgo+IEZ1cnRoZXJtb3JlLCB0aGUgc3RyaW5nIHJldHVybmVkIGJ5IHhtbEdldFByb3Ao KSBuZWVkcyB0byBiZSBmcmVlZAo+IHdpdGggeG1sRnJlZSgpLCBidXQgdGhpcyBpcyBub3QgZG9u ZSBlaXRoZXIuCj4KPiBUaGlzIGNvbW1pdCBmaXhlcyBib3RoIG9mIHRoZXNlIGlzc3VlczsgdGhl eSBleGlzdGVkIHNpbmNlIHRoaXMgY29kZQo+IGhhcyBiZWVuIGFkZGVkIGluIDEwZDAwOGYwZmQ5 ZTcxM2UyOTBmNjI2MzAwZDY2MzgyYWQ3ODZjNDkuCj4KPiBUaGlzIGhhcyBiZWVuIGZvdW5kIHdo aWxlIGludmVzdGlnYXRpbmcgdGlja2V0ICM5Njk3LiBUaGUgY29udGludW91cwo+IGxlYWtzIG1p Z2h0IHZlcnkgd2VsbCBiZSB0aGUgcmVhc29uIGJlaGluZCB0aGUgb2JzZXJ2ZWQgc2xvd2Rvd24u Cj4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZWFzIFJoZWluaGFyZHQgPGFuZHJlYXMucmhlaW5oYXJk dEBvdXRsb29rLmNvbT4KPiAtLS0KPiAgbGliYXZmb3JtYXQvZGFzaGRlYy5jIHwgNyArKysrKyst Cj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRp ZmYgLS1naXQgYS9saWJhdmZvcm1hdC9kYXNoZGVjLmMgYi9saWJhdmZvcm1hdC9kYXNoZGVjLmMK PiBpbmRleCA2M2JmN2U5NmE1Li4yY2E5MWJlYThiIDEwMDY0NAo+IC0tLSBhL2xpYmF2Zm9ybWF0 L2Rhc2hkZWMuYwo+ICsrKyBiL2xpYmF2Zm9ybWF0L2Rhc2hkZWMuYwo+IEBAIC05NTYsNyArOTU2 LDExIEBAIHN0YXRpYyBpbnQgcGFyc2VfbWFuaWZlc3RfcmVwcmVzZW50YXRpb24oQVZGb3JtYXRD b250ZXh0ICpzLCBjb25zdCBjaGFyICp1cmwsCj4gICAgICAgICAgICAgIHhtbEZyZWUodmFsKTsK PiAgICAgICAgICB9Cj4gICAgICAgICAgaWYgKGFkYXB0aW9uc2V0X3N1cHBsZW1lbnRhbHByb3Bl cnR5X25vZGUpIHsKPiAtICAgICAgICAgICAgaWYgKCFhdl9zdHJjYXNlY21wKHhtbEdldFByb3Ao YWRhcHRpb25zZXRfc3VwcGxlbWVudGFscHJvcGVydHlfbm9kZSwic2NoZW1lSWRVcmkiKSwgImh0 dHA6Ly9kYXNoaWYub3JnL2d1aWRlbGluZXMvbGFzdC1zZWdtZW50LW51bWJlciIpKSB7Cj4gKyAg ICAgICAgICAgIGNoYXIgKnNjaGVtZV9pZF91cmkgPSB4bWxHZXRQcm9wKGFkYXB0aW9uc2V0X3N1 cHBsZW1lbnRhbHByb3BlcnR5X25vZGUsICJzY2hlbWVJZFVyaSIpOwo+ICsgICAgICAgICAgICBp ZiAoc2NoZW1lX2lkX3VyaSkgewo+ICsgICAgICAgICAgICAgICAgaW50IGlzX2xhc3Rfc2VnbWVu dF9udW1iZXIgPSAhYXZfc3RyY2FzZWNtcChzY2hlbWVfaWRfdXJpLCAiaHR0cDovL2Rhc2hpZi5v cmcvZ3VpZGVsaW5lcy9sYXN0LXNlZ21lbnQtbnVtYmVyIik7Cj4gKyAgICAgICAgICAgICAgICB4 bWxGcmVlKHNjaGVtZV9pZF91cmkpOwo+ICsgICAgICAgICAgICAgICAgaWYgKGlzX2xhc3Rfc2Vn bWVudF9udW1iZXIpIHsKPiAgICAgICAgICAgICAgICAgIHZhbCA9IHhtbEdldFByb3AoYWRhcHRp b25zZXRfc3VwcGxlbWVudGFscHJvcGVydHlfbm9kZSwidmFsdWUiKTsKPiAgICAgICAgICAgICAg ICAgIGlmICghdmFsKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgYXZfbG9nKHMsIEFWX0xPR19F UlJPUiwgIk1pc3NpbmcgdmFsdWUgYXR0cmlidXRlIGluIGFkYXB0aW9uc2V0X3N1cHBsZW1lbnRh bHByb3BlcnR5X25vZGVcbiIpOwo+IEBAIC05NjUsNiArOTY5LDcgQEAgc3RhdGljIGludCBwYXJz ZV9tYW5pZmVzdF9yZXByZXNlbnRhdGlvbihBVkZvcm1hdENvbnRleHQgKnMsIGNvbnN0IGNoYXIg KnVybCwKPiAgICAgICAgICAgICAgICAgICAgICB4bWxGcmVlKHZhbCk7Cj4gICAgICAgICAgICAg ICAgICB9Cj4gICAgICAgICAgICAgIH0KPiArICAgICAgICAgICAgfQo+ICAgICAgICAgIH0KPgo+ ICAgICAgICAgIGZyYWdtZW50X3RpbWVsaW5lX25vZGUgPSBmaW5kX2NoaWxkX25vZGVfYnlfbmFt ZShyZXByZXNlbnRhdGlvbl9zZWdtZW50dGVtcGxhdGVfbm9kZSwgIlNlZ21lbnRUaW1lbGluZSIp Owo+IC0tCj4gMi4zNC4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IGZmbXBlZy1kZXZlbCBtYWlsaW5nIGxpc3QKPiBmZm1wZWctZGV2ZWxAZmZt cGVnLm9yZwo+IGh0dHBzOi8vZmZtcGVnLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZmbXBlZy1kZXZl bAo+Cj4gVG8gdW5zdWJzY3JpYmUsIHZpc2l0IGxpbmsgYWJvdmUsIG9yIGVtYWlsCj4gZmZtcGVn LWRldmVsLXJlcXVlc3RAZmZtcGVnLm9yZyB3aXRoIHN1YmplY3QgInVuc3Vic2NyaWJlIi4KCgpw YXRjaHNldCBsZ3RtCgoKVGhhbmtzClN0ZXZlbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGluZyBsaXN0CmZmbXBlZy1kZXZl bEBmZm1wZWcub3JnCmh0dHBzOi8vZmZtcGVnLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZmbXBlZy1k ZXZlbAoKVG8gdW5zdWJzY3JpYmUsIHZpc2l0IGxpbmsgYWJvdmUsIG9yIGVtYWlsCmZmbXBlZy1k ZXZlbC1yZXF1ZXN0QGZmbXBlZy5vcmcgd2l0aCBzdWJqZWN0ICJ1bnN1YnNjcmliZSIuCg==