From: Steven Liu <lingjiujianke@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_opt: add a stream_group_script option
Date: Mon, 8 Jan 2024 09:43:08 +0800
Message-ID: <CADxeRw=Q1Mey6X8bu-tcF7fKU2Sixqur09m2gh8dh1x+rhbxuw@mail.gmail.com> (raw)
In-Reply-To: <20240107213100.16205-3-jamrial@gmail.com>
James Almer <jamrial@gmail.com> 于2024年1月8日周一 05:31写道:
Hi James,
>
> Similar to filter_complex_script. Should make setting stream groups
> easier.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> fftools/ffmpeg_mux_init.c | 2 +-
> fftools/ffmpeg_opt.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> index 80109df0ae..1b42ac9a1d 100644
> --- a/fftools/ffmpeg_mux_init.c
> +++ b/fftools/ffmpeg_mux_init.c
> @@ -2301,7 +2301,7 @@ static int of_add_groups(Muxer *mux, const OptionsContext *o)
> char *str, *ptr = NULL;
> int ret = 0;
>
> - str = av_strdup(o->stream_groups.opt[i].u.str);
> + str = av_strireplace(o->stream_groups.opt[i].u.str, "\n", "");
> if (!str)
> return ret;
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 7ae1b55cf0..7347fcbd31 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -1508,6 +1508,9 @@ const OptionDef options[] = {
> { "stream_group", OPT_TYPE_STRING, OPT_SPEC | OPT_OUTPUT,
> { .off = OFFSET(stream_groups) },
> "add stream group with specified streams and group type-specific arguments", "id=number:st=number..." },
> + { "stream_group_script", OPT_TYPE_FILE, OPT_SPEC | OPT_OUTPUT,
added documentation about this option yet?
> + { .off = OFFSET(stream_groups) },
> + "read stream group with specified streams and group type-specific arguments from a file", "filename" },
> { "dframes", OPT_TYPE_FUNC, OPT_FUNC_ARG | OPT_PERFILE | OPT_EXPERT | OPT_OUTPUT | OPT_HAS_CANON,
> { .func_arg = opt_data_frames },
> "set the number of data frames to output", "number",
> --
> 2.43.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-08 1:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 21:30 [FFmpeg-devel] [PATCH 1/4] avformat/iamfenc: don't write empty packets James Almer
2024-01-07 21:30 ` [FFmpeg-devel] [PATCH 2/4] fftools/cmdutils: add OPT_TYPE_FILE James Almer
2024-01-07 21:30 ` [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_opt: add a stream_group_script option James Almer
2024-01-08 1:43 ` Steven Liu [this message]
2024-01-08 1:44 ` James Almer
2024-01-07 21:31 ` [FFmpeg-devel] [PATCH 4/4] fate: add raw IAMF tests James Almer
2024-01-10 3:05 ` Michael Niedermayer
2024-01-10 12:52 ` James Almer
2024-01-11 3:17 ` Michael Niedermayer
2024-01-11 12:02 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADxeRw=Q1Mey6X8bu-tcF7fKU2Sixqur09m2gh8dh1x+rhbxuw@mail.gmail.com' \
--to=lingjiujianke@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git