From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6BA8647CF3 for ; Tue, 15 Jul 2025 07:45:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9FD9B68DC65; Tue, 15 Jul 2025 10:45:23 +0300 (EEST) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1125368DAEE for ; Tue, 15 Jul 2025 10:45:17 +0300 (EEST) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4ab6416496dso25063681cf.1 for ; Tue, 15 Jul 2025 00:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752565515; x=1753170315; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=GC5KRgc4u0KCyf6w78924nCglb/04Qeq0ecJO/IO4sU=; b=UbQ/TXTuEujR41BWm6IktpAFXyohcybfx4C0A7oSXCGRU0K1zv7/OpF3gNuVsHvrmC 8Wm5cVh6/Nox7f80RxT89D4dwOclFhiTN6r+I87O2nSmbxGg3GPbxiu23ciaGalLMmN3 Is1iUVZ/puEqrxspnWybHLimxOHwf6f8IL7w1HogcNEIuCf2EZEOCiaSZHmVUGZk387Y Eus7Gh1XWwsVyQtbIlyGG3cQppiIGjPToOqDEcHTdd/1D4djz/Fcm4DQvPEjC1MpKRtL Tmky2RIH0L4LiPR+16k/BN0asa1PJitevPEZpnn3wGNPqUZ80420StwvR2Wd3U7Jhpyc xXIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752565515; x=1753170315; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GC5KRgc4u0KCyf6w78924nCglb/04Qeq0ecJO/IO4sU=; b=rJw5a4NhRjWiR5CgpJgs6QMni2dkv/9aZWCwTiu4rjvwcFsI5SnP+BP0JEEy+/dSxe 2o5L+K/EW60XIrfYwuyWjnZewbY8jF6L9jHukg/DDMyyNbU/G3llAoaTCiP0OTSKMjwz OAjwXo0auKDDxC4Fu1s090QYaw3MXDgrnGZB/e5Pjw7dRZbLvQ1esWWh/as2d9seWoTw ZKMr1gRz5EEkZ7ITwlG1yMw+/dF5m3I/JL3UttD+gkvP21opeRDgVlkK9CuV5uUUbmgZ fSV6LcMRWbSO6Jy7BUSDM3fJ/31yMtBSKTXc6aGRPhXesojkgA5377xeEqx6K3LnrFLx dMgA== X-Gm-Message-State: AOJu0YxNGvR4g7Qx3L7iyL8gV8P1xz59b0GgVaN7Lws9XCPd0t/RqNIO OgrUp/uHz8n6FopHbP7Hi5OVLWk8ZGnxrSfF1k1Lsv2Q7s7UuH8SdZFhmlc2s+cLtkCQ9wR29AQ HH/8jaNryfrWXC3WPWgTcTEoEneRi/KbsBQxw X-Gm-Gg: ASbGncvKUI15Pk79F7eSMZp5ql9Qh4xOEIMRTG7eNz7+rSCiK0dzaB1nU3dLSXZSp/b P/kyd8yTzC95r3dKGdR8eOyU0pnIwWHtRNvopYHDaKv1C4EijBWabdgCDg+rUVDnmGgz927P8vA p4xfAxiGdGMn9MGoQoR4nZPmK576Dhcpik+6nyv9rSBaQBtq8riygFr8wnMe3LrNRJOejxb+AVL cyI X-Google-Smtp-Source: AGHT+IFAtzSXLGu55aWOLpkmOSe/GCC0cJXPBVdjIDZf6sFfS9u+8a4g8NVW7F4S5TbjVJjwiVEubentyP1W5IJOy84= X-Received: by 2002:ac8:57c4:0:b0:4ab:5abf:f328 with SMTP id d75a77b69052e-4ab825aca97mr20780841cf.26.1752565515102; Tue, 15 Jul 2025 00:45:15 -0700 (PDT) MIME-Version: 1.0 References: <20250710102543.1002696-1-vpalmisano@gmail.com> <20250710122008.GP29660@pb2> <20250712000330.GX29660@pb2> <20250714214713.GO29660@pb2> In-Reply-To: <20250714214713.GO29660@pb2> From: Vittorio Palmisano Date: Tue, 15 Jul 2025 09:44:48 +0200 X-Gm-Features: Ac12FXyrkx_ilXiEeAyrHnY7aC9caR2CZyW2I5YVqKotDaQuVC-1yuYNYjQI5ig Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Whisper audio filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > +@item gpu_device > > +The GPU device to use. > > +Default value: @code{"0"} > > is this always a number ? > if so the documenattion could say that Yes, it is the device index. > > +@item destination > > +If set, the transcription output will be sent to the specified file or URL > > +(use one of the FFmpeg AVIO protocols); otherwise, the output will be logged as > > +info messages. > > +The output will also be set in the "lavfi.whisper.text" frame metadata. > > teh documenattion should elaborate on what happens if the destination already > exists Ok > > + if (!av_strcasecmp(wctx->format, "srt")) { > > + buf = > > + av_asprintf > > + ("%d\n%02ld:%02ld:%02ld.%03ld --> %02ld:%02ld:%02ld.%03ld\n%s\n\n", > > + wctx->index, start_t / 3600000, > > + (start_t / 60000) % 60, (start_t / 1000) % 60, > > + start_t % 1000, end_t / 3600000, (end_t / 60000) % 60, > > + (end_t / 1000) % 60, end_t % 1000, text_cleaned); > > + } else if (!av_strcasecmp(wctx->format, "json")) { > > + buf = av_asprintf("{\"start\":%ld,\"end\":%ld,\"text\":\"%s\"}\n", > > start_t, end_t, text_cleaned); > > + } else > > + buf = av_strdup(text_cleaned); > > Do you think it would make sense to use avcodec_encode_subtitle() ? > It would avoid hardcoding these "writers" and could use any we support avcodec_encode_subtitle should be used to generate a subtitle track, right? I'm checking how it is used. > also please make sure to attach the next attach in a way that doesnt corrupt it. > (i used the forgejo pr to test and read most of this but i think my reply > is not very readable as i replied to the mail) Ok I will use git send-email. Feel free to comment on https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/17/files too. Thanks _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".