Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Vittorio Palmisano <vpalmisano-at-gmail.com@ffmpeg.org>
To: Michael Niedermayer <michael@niedermayer.cc>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Whisper audio filter
Date: Thu, 10 Jul 2025 10:34:50 +0200
Message-ID: <CADv15W9uJYpiPMUW=AknUCqaZd1oa6T=L7zNEJWtmY0-GNU5Ug@mail.gmail.com> (raw)
In-Reply-To: <20250709233746.GM29660@pb2>

Thanks Michael, I will try to answer your comments.

> > +ffmpeg -i input.mp4 -vn -af "aformat=sample_rates=16000:channel_layouts=mono,whisper=
>
> Is there a reason why we convert to 16khz mono here ?

It is the only format supported by the whisper.cpp library.

> > +model=../whisper.cpp/models/ggml-base.en.bin\
>
> It would be nice if the models would be in a standard location, so teh user
> just has to specify the model name and not the path

I think that this functionality should be implemented inside the
whisper.cpp library, so they can manage the exact model location and
the download process. I will propose a change.

> I tried this:
>
> ./ffmpeg -i matrixbench_mpeg2.mpg -vn -af "aformat=sample_rates=16000:channel_layouts=mono,whisper=model=/home/michael/whisper.cpp/models/ggml-base.en.bin:language=en:queue=3000:destination=output.srt:format=srt" -f null -
>
> but the output.srt is empty (0 bytes)

Can you enable verbose logging?

> libavfilter/af_whisper.c:75:49: error: parameter name omitted
>    75 | static void cb_log_disable(enum ggml_log_level, const char *, void *) {}
>       |                                                 ^~~~~~~~~~~~
> libavfilter/af_whisper.c:75:63:

I don't see this error using the gcc13 compiler. Do you use a
different compiler or some other flags?

> > +    wctx->audio_buffer_fill_size = 0;
> > +
> > +    wctx->next_pts = AV_NOPTS_VALUE;
> > +
> > +    wctx->avio_context = NULL;
>
> arent things already initialized to 0 ?

Yes, maybe we can keep the AV_NOPTS_VALUE assignment (it is not zero).

-- 
/Vittorio Palmisano/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-07-10  8:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  7:23 Vittorio Palmisano
2025-07-09 13:36 ` Marvin Scholz
2025-07-09 15:24 ` Zhao Zhili
2025-07-10  8:43   ` Vittorio Palmisano
2025-07-10  9:47     ` Zhao Zhili
2025-07-10 12:41   ` Michael Niedermayer
2025-07-09 23:37 ` Michael Niedermayer
2025-07-10  8:34   ` Vittorio Palmisano [this message]
2025-07-10 10:05     ` Marvin Scholz
2025-07-10 10:20       ` Vittorio Palmisano
2025-07-10 10:25         ` Vittorio Palmisano
2025-07-10 12:20           ` Michael Niedermayer
2025-07-10 11:31     ` Michael Niedermayer
2025-07-10 12:07       ` Nicolas George
2025-07-10 12:10         ` Nicolas George
2025-07-09 23:41 ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADv15W9uJYpiPMUW=AknUCqaZd1oa6T=L7zNEJWtmY0-GNU5Ug@mail.gmail.com' \
    --to=vpalmisano-at-gmail.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=michael@niedermayer.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git