From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 815C542B35 for ; Thu, 25 Aug 2022 07:47:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3176668B99A; Thu, 25 Aug 2022 10:47:05 +0300 (EEST) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AABF068B737 for ; Thu, 25 Aug 2022 10:46:59 +0300 (EEST) Received: by mail-ej1-f54.google.com with SMTP id j21so32499039ejs.0 for ; Thu, 25 Aug 2022 00:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=GCsuQs+4x6c7a1BbihEHwv+SJJQu6+Pa8V1V2RBP4nU=; b=UiacrR0Kaev8To7o9NcyvOkzkcFyk2o7ZS4byR8Wp789+P571CVKQ1FmnbLoLmJqmA YePXUVqq3c6g9KcEOO6NgP80ZgWm5nGBkpk/2/vg4MJ98VRIwVEq8diSVMj3pTQK0MU9 nzeHF7cRR+mVflox/r9GOhJfMiPM1jcujBRMsuJv53j+EtweTfJSIZGSSFxT/5IDrRLQ yyTv0wWu6wKyqyVDHiVSMTjY2wJZqmv2lzAYTgt1vpx2DDADre9bWuv08WjGsIW2AYQh RniYx3zsqswo2ElqlghqHa4EBvz3jYztT3L/M2NaLu9DDvlNJA6DjFx8xwaia0qIhviy NOKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=GCsuQs+4x6c7a1BbihEHwv+SJJQu6+Pa8V1V2RBP4nU=; b=S1FM4UXv7X7Tsq9iZ0a/BqpllA7EJ7VH5Ru4b/ky/2gZ4gN1bZQzE0gyTtP3FEHqBp F8UrW+Q/+RxgSQg6cN02BPGkMMEVnW0+jRbiZiUQy9OhlfUS3d/GuVoLhvTRX2Ak9eyF j+jWcth1Q938ifnAFgjJk9bMiwJxypsKa5pHGI4dS/Z276yViElfqQnclSFqqM7zMgAa YkPbiGhCFEOFTFiZaBY66ThzjIouMd0h0TQm5nQ96f20zbADkeQL1qvR97HDrTxFkR+S xmCjic+5nPA0h653hV1aKD9XPKGS3qN2WrUBNqQ4rfMTHgeOcuInj1pOcZ2QGSAdGLQS rwIg== X-Gm-Message-State: ACgBeo2y50qxTEygdR10tOm0bHjLYiNejXEU3RtUxvx+6K8410jX7zAi zuYY+fAHwJLmt6oc8ufF5X2A77T5ttdS/32Yg6KbhYi5+C8= X-Google-Smtp-Source: AA6agR615dFDE+fIDRGsl3QFNVcsecUrT1Ob+Tdp5UvD7T49qN0DylhuGptY6bVgiGgPJuGdEevCfeMz/efwasGmjyw= X-Received: by 2002:a17:906:fd8d:b0:73a:7424:6c0d with SMTP id xa13-20020a170906fd8d00b0073a74246c0dmr1636243ejb.425.1661413618279; Thu, 25 Aug 2022 00:46:58 -0700 (PDT) MIME-Version: 1.0 References: <20220208110240.4179-1-qyot27@gmail.com> <20220208110240.4179-3-qyot27@gmail.com> <8a7161a1-ef76-0958-ba9e-8ecf7b7fa998@gmail.com> In-Reply-To: <8a7161a1-ef76-0958-ba9e-8ecf7b7fa998@gmail.com> From: Steinar Apalnes Date: Thu, 25 Aug 2022 09:46:47 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/3] avisynth: use AviSynth+'s frame properties to set various fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: tor. 25. aug. 2022 kl. 02:11 skrev Stephen Hutchinson : > On 8/24/22 1:04 PM, Steinar Apalnes wrote: > > tir. 8. feb. 2022 kl. 12:03 skrev Stephen Hutchinson : > > > >> * Field Order > >> * Chroma Location > >> * Color Transfer Characteristics > >> * Color Range > >> * Color Primaries > >> * Matrix Coefficients > >> > >> The existing TFF/BFF detection is retained as a fallback for > >> older versions of AviSynth that can't access frame properties. > >> The other properties have no legacy equivalent to detect them. > >> > >> Signed-off-by: Stephen Hutchinson > >> > > ....... > > Hi Stephen, > > > > Would it be possible to add support for "_SARum" and "_SARDen" so that > > ffmpeg could also recognize the sample aspect ratio in avs scripts? > > > > I'm a bit hesitant to do so, namely because the _SARNum/Den properties > are much more likely to need to have been changed due to operations > in-script, and unless the user is studious about updating those > properties after even just a basic resizing operation, then _SARNum/Den > will still be set to the original values populated by the source filter, > and will be wrong, leading to encodes ending up wrong and potentially > bug reports to Trac which aren't actually the fault of the demuxer. > > This is partially coming from the fact that even the color-based > properties that were already added have experienced some level of > backlash because of the requirement for users to ensure the properties > are correctly updated if they've done any changes to those factors > (as best as I'm aware, the filters in the AviSynth+ core still only pass > through the existing properties, but they don't update them if they > pertain to that property's functionality; I believe some external > filters do update them, however). I would be fairly confident in > betting that users resizing video is far more common than them doing > color correction ops that would require updating the frameprops FFmpeg > can currently read. > > One mitigation to that, IMO, would be to flag that as an experimental > feature, making it to where FFmpeg won't read _SARNum/Den unless > the -strict option has been used. > _______________________________________________ > > If you think cherry picking what props to support under normal operation is the way to go then a -strict option to support *all* "scary" avs props would be very welcome indeed. Because as it is now we have nothing at all in regards to the SAR. Thanks for your efforts :-) -steinar _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".