From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6923A4834D for ; Tue, 28 Nov 2023 14:32:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 104E468CFA7; Tue, 28 Nov 2023 16:32:54 +0200 (EET) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C57568CF61 for ; Tue, 28 Nov 2023 16:32:47 +0200 (EET) Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7b3854d7270so134470339f.3 for ; Tue, 28 Nov 2023 06:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701181965; x=1701786765; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=xH+erTg4oWVVq2NVZtCTFP6wqbqRtaaEpM77bkDJulg=; b=QcTwveTteP4HQJ3wq5hW0eg7xBabtFHnoRoeqT/b1tnrFx4KuNWIASu353eEyK5Pkg Bk//pKbSFJaycupP8LtnUJbySgTerSkuq1CJp/l/Man7saz/1bwLUvZ1Vre4+zEMKxKA IH7vEF3gibFtwNMvEOYF/Q2+M6vW51fxCz4KNG2GQfz4GDb8kkRcYYKJAujKUbKoHIQW EBzWSIGMRLTdw/NbGGRRoA+BcM3AtWJeu1k3seS2fBrU0Qq7uGnsSsbSft+Iw0/bPCqq LFARW7PT1aKOLJQspnrzZ3uD/rk/hoWmMH85BXQ4Idk9s3xe491vBBp3S2SvlksbWfvA Su2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701181965; x=1701786765; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xH+erTg4oWVVq2NVZtCTFP6wqbqRtaaEpM77bkDJulg=; b=g0l3Qmw4wzpD6TZJOGLDR1X8aiXAGDh8rPm1eXV2YSCETdpcjzZm52qTv7fmac7eP+ t9uLvPCTiFNREXZSsYAyU1Nynh01cOzbvYaUIoZF8yGqmysAXxFMJxBEdmTsobin2d// F1b/pRjxLAhy53VZYoQf+abbuNxQm8HAC7RRT9aLhz8cFidClKX7LMuFvox9xL02xoJY LGit1K6vhWSMJpWSeTvPmyrYzhKi5VBepShwZt8U8DfxJ0u17rH8OJwi7X9qeCTbbOAE M/8TyIu4GJHyUvlZzmkj5+DibeemkyL/FW4sreOec0fK2sGjNIzi95Z0zLZdLX4Wb4mG woIA== X-Gm-Message-State: AOJu0Ywv2pkqQ9Gf8avNycYYbIKsjeRgtqMlmD9PdmNjafllBE7p2L/7 YQ49ajdu8nd63A41QBm0VUkspbidkBXCvX3ujm3roaZgwf+AqYyk X-Google-Smtp-Source: AGHT+IFq0ZeZIViEQn20j4UvDdrCSskn6g4T2M2Ia7Q3SYc0NVBP9SmqV4/ljR9umolrNPaXwQ/PXthF2VS6LX1JzCo= X-Received: by 2002:a05:6602:13:b0:7b3:91fa:49c4 with SMTP id b19-20020a056602001300b007b391fa49c4mr13469505ioa.10.1701181965293; Tue, 28 Nov 2023 06:32:45 -0800 (PST) MIME-Version: 1.0 References: <20231123094246.14268-2-lucenticus@gmail.com> <170099475357.8914.510238847473742047@lain.khirnov.net> In-Reply-To: From: Evgeny Pavlov Date: Tue, 28 Nov 2023 15:18:54 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > > Seems like we could template this to avoid the duplication, something like: > > #define PER_CODEC_OPTION(name) \ > (ctx->codec == AV1 ? AMF_VIDEO_ENCODER_AV1_ ## name : \ > ctx->codec == HEVC ? AMF_VIDEO_ENCODER_HEVC_ ## name : \ > AMF_VIDEO_ENCODER_ ## name) > Thanks for the suggestion, I've extracted duplicated code to amfenc.c file, but can't extract the whole smart_access_video option, because there are some differences between av1 & hevc/h264 encoders while set low latency mode. In addition, I've added a more detailed description for SAV option, I hope it will be enough for understanding. Here is an updated version of this patch: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20231128135347.892-2-lucenticus@gmail.com/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".