From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1177C40678 for ; Tue, 25 Oct 2022 15:56:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F08068BA9B; Tue, 25 Oct 2022 18:56:11 +0300 (EEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A212868B82B for ; Tue, 25 Oct 2022 18:56:04 +0300 (EEST) Received: by mail-pg1-f180.google.com with SMTP id 128so11889751pga.1 for ; Tue, 25 Oct 2022 08:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=/VYDSpx1PzxH5vjr6LQWqww8PfCB1xEi4C/AQncRSB0=; b=LYLKRoIxY4r6mW3tGEH7hcso39r483uSMGj5GlSRtdm9zQtZ+7R6twwCu3XkfUNwxY VfJQn5gdfw1iPaaoV64HkG20/ZcLkz/5McdDEG4wsLQgm0z11vw1rjm2Y2DcH35F3wFg 6Imc/cKw5thQjatOLpxMScI1AI/Jj02BCm/SwMTte9HcpT9u3at/xzzxNuwRlmTyUAqY ouES6j0uMk6EowzZ311fLkUVysKad85Tmube6RnZpKlKMafUxiRVxyQl0Ao47uRCj/Vk 2ngeiCEz+/4N6WV4B9bQiZD5fjWEzZDxXL2N9z+CoYXK1+OorsyUJyll/Jnzjm+lXSzn XWEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/VYDSpx1PzxH5vjr6LQWqww8PfCB1xEi4C/AQncRSB0=; b=6CEcxa/FnApH596yMAl05BH4Bb2xGFvukspO95JRYzlYa4GBCyohbIsh1XnsKAQewi fITiL5Pg+r5KE7cSNT6nRfsqjb7oDFnyGfPbOuVj9qo2agV0bg4k9Z2ZvoUwZ+Sg4Ed9 Fa0JZoBDvAXKbYHIFnNPBjbX4sen3i2IrIpZix/ttxxqelc39jGfoHtiaS/RhflbPLuQ dnsq6pFPot/nwnZgYvZrvKswdSTYjt6pR7p3gLnhcTI7z9y18p1GQDs/6FQKGUEExp0E aEj0THRPrRXsRHJL2xTXXstSYao7At/zTX9/JChXQ/brei7H21JItWc0ZYY/SU3sOzsL mAxg== X-Gm-Message-State: ACrzQf2AuPOfXpiiFFKPFDkQVx0nGopx862mkhkwqYRszHrkQ9btoBxf jSnt+QmioaNEP6d/wR1xiUVGAVJAOKNwPZ+b8aokl5ddDHtOvg== X-Google-Smtp-Source: AMsMyM4eKIp9C5KeHQnehJnUrWFZhW4uWbkRCUSedQZupaJqbCOMR5VT7qiG5Tdkc168GFAidGdNv58RKFyQGrTjwVk= X-Received: by 2002:a63:87c7:0:b0:434:883:ea21 with SMTP id i190-20020a6387c7000000b004340883ea21mr34594090pge.152.1666713362225; Tue, 25 Oct 2022 08:56:02 -0700 (PDT) MIME-Version: 1.0 References: <20221006134959.771-1-ovchinnikov.dmitrii@gmail.com> In-Reply-To: From: Dmitrii Ovchinnikov Date: Tue, 25 Oct 2022 17:55:48 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH V2] lavc/libvpx: increase thread limit to 64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >> Why do you still impose an upper limit unconditionally even if the >>user has set his preferred number of threads? Libvpx-vp9 does not support number of threads greater than 64, so we impose an upper limit of 64. E.g. if we set it any higher we get the following execution error: [libvpx-vp9 @ 0x2f631c0] Failed to initialize encoder: Invalid parameter [libvpx-vp9 @ 0x2f631c0] Additional information: g_threads out of range [..64] Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height >>According to https://ffmpeg.org/pipermail/ffmpeg-devel/2018-November/236406.html the >>maximum of 16 has not been chosen because of H.264, but because there >>was some form of restriction in libvpx. Or at least there was belief in >>the existence of such a restriction. There is a restriction of maximum 64 threads, not 16. >>This code potentially calls av_cpu_count() twice. Can you please clarify how it calls it twice? Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".