From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B512347AB0 for ; Thu, 30 Nov 2023 10:58:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B5B3768D060; Thu, 30 Nov 2023 12:58:31 +0200 (EET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C33DC68CD16 for ; Thu, 30 Nov 2023 12:58:24 +0200 (EET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6cdd4aab5f5so787111b3a.3 for ; Thu, 30 Nov 2023 02:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701341902; x=1701946702; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Bk/hnxxcFqd2Q9hoebDEp3nzeM/wCRcQ/xPeXkAiMto=; b=iqqk+FEK5hEaPHWdffPg21lXZliKVIqEs5Igus2xtUaXzliHQ6k0HCU5kAfMFhWf7y 5PNA8ezI2c5PsfKXpJuXlvSaiyOEGhfa9ZidKzsrQBxm6XNN6bZVMWROIReRWtkB1TOg i14liNRXiq61N/xr8WaWl2OvFZOGUlQsdN4mRICu6S6Z77cTRENd0abHZdXmRiJLmCDQ 6jnUrhUGCjlSpf0+uLVffgqsS9lGEzrdlSA4MM16S2zTiTIol/siOXLnDQvamklZUa8W 3vZ4uYnaxqoaFGrsbjM5iOuN8j6IgK6hL1TlBHXqE/pUnLxZ4YTVrIcxgl9bNplIvAQD 6lRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701341902; x=1701946702; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bk/hnxxcFqd2Q9hoebDEp3nzeM/wCRcQ/xPeXkAiMto=; b=PRZMPFd6sqAHWiTLFceniDINM74dvjudNf1/P84dB+Eo9XzGiGDkMTDBmNObgz9DlU 6qSEILt9MvzJHTK/cY207qy2NazzjlhbbVwFklivbRDBDyoAzphXYVrCYfRvivqQxFgd 17pYWNxe98RxvGpJXpcw9NnGjlXQAXgA/V14VKUOIvPV2Ji/7CzzkUhMVwkw9uIHYT4w jTvxWlw98GbmZbH3BgOmWPKPcOnFELz6vBtBcrxjUABqgYVMnt7428RQopzuRAMhqaY6 4AOF93xSrETt5tNMOwTMlrRmVTkpCdF0k6RihOaqQ/cJgKUDt4WmKk/+Zf6xLjj9Zlf6 guYg== X-Gm-Message-State: AOJu0YwI57Ij5ZaSQp0xT/YtCAUpv6D8MQby2w4bWk48ZDNubrqNs20w TAMsu2fkFN6nwtizWt8T1fKzGYQUxJl+C4Pr134L7eGBICo= X-Google-Smtp-Source: AGHT+IENC2UWPhzDK2i/vNCQkYYkv0Gp+RtWLmV2AoGuhupvi/d6oDmFJbMOwRT73llTLIUdi1JTD3Otxv+WQaJn0f8= X-Received: by 2002:a05:6a20:9e4d:b0:188:1281:8994 with SMTP id mt13-20020a056a209e4d00b0018812818994mr26035307pzb.35.1701341902190; Thu, 30 Nov 2023 02:58:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dmitrii Ovchinnikov Date: Thu, 30 Nov 2023 11:58:10 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amd: fix pict_type, match it with amf & ffmpeg. add sps pps when frame->keyframe X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The idea itself looks good to me, but the patch is corrupted. Regarding the patch: 1) >>// Keyframe overrides previous assignment. It might be better instead of: setting the frame type -> if key frame then overwrite to do: check for key frame and if it's not, set other PICTURE_TYPE to avoid unnecessary overwriting (use AV_FRAME_FLAG_KEY instead of deprecated key_frame, as already noted under the second patch) 2) The patch includes logic for AV_CODEC_ID_H264 and AV_CODEC_ID_HEVC, but not for AV_CODEC_ID_AV1.( FORCE_INSERT_SEQUENCE_HEADER AMF_VIDEO_ENCODER_AV1_FORCE_FRAME_TYPE ) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".