From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8E571487B9 for ; Wed, 17 Jan 2024 18:39:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF86A68CC8A; Wed, 17 Jan 2024 20:39:22 +0200 (EET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EEFCE68CC51 for ; Wed, 17 Jan 2024 20:39:15 +0200 (EET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-28e703fd835so1989809a91.1 for ; Wed, 17 Jan 2024 10:39:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705516753; x=1706121553; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Ui9n1pKCS/iUo5HkfO3BdZjcd7CKsGUNbe+M4HhxM/o=; b=ISghlnZPnANk5EVp6/oxHXVCbGhIbXZVOQYyOrjxlFHIXfNi2GMcVLDhJF2n15Ae1f zncTDH4GWg/DcJefO5WUiY1ln/cKJW9FcJuC/gez9lldqc+2oHx2SegzDaM3Jj6JW8lw +i0gNgBy2o/CH377oAHnMfm3kXr8gzhMKK/9t7X+xLXYQFdY2OHersw55ITYtu7jvEAI ewkjM8ixE9tuG0urHEqz1S2NLibtxHuxjjfQ+vTBXxnVn46LHfT8W36NKhY0AR2JbEWS ofMXf538iqvsDtqN7eUTJxxA2gFUWfg4FbDpRBFqvkur14GbXSPw3HowrhI+UKOFjmkC SkrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705516753; x=1706121553; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ui9n1pKCS/iUo5HkfO3BdZjcd7CKsGUNbe+M4HhxM/o=; b=R8mv7IyLjbZpytPVVOeonGW3g+mPadQWZYvJxzG8Jn4g6ObIVAEJwIzVq89tZpt2wg ZZb70xFuRppRMtDBnj2Tdvku/ygXUob6kHs68Qu8WhzLkUerAwRA976YglZ0w/0lG0QW UD0Jc/cLA5HAMNEjyVqi++ojbzMnPQnPaFU+f1yrZQe7tVf43XQA7KrUQRoNlTi5y/Cp fnmksa6DhL5WWkGl+6HYOZJ+Ao2o9Yhrhxq2TzQ4lRT7r221q4X8vlhK2Si39v4Ec0Oc Ev3PtDeAAVbrWbKLX61+HxjsPVRR5ozTk3c4p9y5Mrwz8OFsDbiH1ViSPLgq7ZvJJYwX F8GA== X-Gm-Message-State: AOJu0Yx258X8WB6ONADBsGTF3Wt2N61uHsKQq+BWOkP3BPLCEPw8pALV +ZIKiPgrP/W7VB1COM+o6eMBBUJeaiFZMCQJvqfTuGVX X-Google-Smtp-Source: AGHT+IF1P+FiE/wubUTy3sFTlJMX4J2DXX+LrJF+e6iM26Gf854NoF70ezjKBB5k7HQeiiPeG3nBxU2WWv+IPK4qvoU= X-Received: by 2002:a17:90b:1b0a:b0:28c:1b98:e6e7 with SMTP id nu10-20020a17090b1b0a00b0028c1b98e6e7mr6418654pjb.47.1705516753664; Wed, 17 Jan 2024 10:39:13 -0800 (PST) MIME-Version: 1.0 References: <20231007162503.1057-1-jamrial@gmail.com> <20231007162503.1057-8-jamrial@gmail.com> In-Reply-To: <20231007162503.1057-8-jamrial@gmail.com> From: Dmitrii Ovchinnikov Date: Wed, 17 Jan 2024 19:39:02 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 7/7] fftools/ffplay: support applying container level cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: I tested these patches with the AMF AV1 encoder(by adding AV_PKT_DATA_FRAME_CROPPING) It works fine. I suggest a small change to the code for better safety. Change this part: >>if (sd->data && sd->size == sizeof(uint32_t) * 4) { to: if (sd && sd->data && sd->size == sizeof(uint32_t) * 4) { This change helps avoid crashes when the cropping data isn't filled in. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".