From: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 7/7] fftools/ffplay: support applying container level cropping
Date: Wed, 17 Jan 2024 19:39:02 +0100
Message-ID: <CADXbNkT-Te6-k25djxyHMxiXN2CZw4Nm8J2-HKM1iY6bMfFBBQ@mail.gmail.com> (raw)
In-Reply-To: <20231007162503.1057-8-jamrial@gmail.com>
I tested these patches with the AMF AV1 encoder(by adding
AV_PKT_DATA_FRAME_CROPPING)
It works fine.
I suggest a small change to the code for better safety. Change this part:
>>if (sd->data && sd->size == sizeof(uint32_t) * 4) {
to:
if (sd && sd->data && sd->size == sizeof(uint32_t) * 4) {
This change helps avoid crashes when the cropping data isn't filled in.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-17 18:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 16:24 [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters James Almer
2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 1/7] avcodec/packet: add a decoded frame cropping side data type James Almer
2023-10-10 11:30 ` Andreas Rheinhardt
2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 2/7] avformat/dump: print Frame Cropping side data info James Almer
2023-10-10 11:03 ` Anton Khirnov
2023-10-07 16:24 ` [FFmpeg-devel] [PATCH 3/7] avformat/matroskadec: export cropping values James Almer
2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing " James Almer
2023-10-10 11:09 ` Anton Khirnov
2023-10-10 11:13 ` James Almer
2023-10-10 11:16 ` Anton Khirnov
2023-10-10 11:21 ` James Almer
2023-10-10 11:28 ` Anton Khirnov
2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 5/7] avformat/matroskaenc: support writing " James Almer
2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg: support applying container level cropping James Almer
2023-10-10 11:13 ` Anton Khirnov
2023-10-07 16:25 ` [FFmpeg-devel] [PATCH 7/7] fftools/ffplay: " James Almer
2024-01-17 18:39 ` Dmitrii Ovchinnikov [this message]
2023-10-10 11:17 ` [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters Anton Khirnov
2023-10-10 11:44 ` James Almer
2023-10-10 11:54 ` Anton Khirnov
2023-10-10 11:58 ` James Almer
2023-10-10 12:12 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADXbNkT-Te6-k25djxyHMxiXN2CZw4Nm8J2-HKM1iY6bMfFBBQ@mail.gmail.com \
--to=ovchinnikov.dmitrii@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git