From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7AFD14826B for ; Wed, 14 Feb 2024 16:48:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 05A0868D1EE; Wed, 14 Feb 2024 18:48:26 +0200 (EET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 145E468D145 for ; Wed, 14 Feb 2024 18:48:19 +0200 (EET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6e0507eb60cso3744142b3a.3 for ; Wed, 14 Feb 2024 08:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707929297; x=1708534097; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Hz5XkFagPAP8nPQQmG9HW1ahniZ/y9m6xByRwFNDiOE=; b=eSyDy0dD2553nUfDCnFeVok01KV+EMEi5yqYpgaWuBquDwSNF6OdeV4k9oVVAZ3KjP 2Ki1L6qUnoOXqhFfYwP4HSvXG57F1wFHbWoN0Xbf/oHEkRtcFnhXR0Yp8+8ZplSjPv5v Tytfx/ESUQIFXD/FClCvAzCVHKTqY+XXJJuUI5m/tgz38DK07R35C867+ZHmaWpeO04j v0ofIaRIqnizxOXE7wnC0tRKKLWbCovROMOOzD7qDmxZHPYm1bUPVVq6sEAHUpiLN9MS iS2Nw/Wb7qCpct5hHgk19fnVFwkDvQDa8AbN5XDu8a5pFouF+ZZnt/epPPtpnuDwy5/g QbAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707929297; x=1708534097; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hz5XkFagPAP8nPQQmG9HW1ahniZ/y9m6xByRwFNDiOE=; b=ExpuclF771zcWlKt9eDzpyGcwzsSYb4w0vOxXxGtpTU3Nw4VMec74/+pP5jEL+BDv8 DyJeBQZyINXNVDE+vYmOIlhHennCcO2+1gCLxTJYkakbSqOG+LjL7d5sV8TY1uIdwiYK sAn/nQ2jNMRkNJt+pTTKxfHLqqFVnZjDznmTR5DUKvV/l/0t1eb5rCVkmor8kO4xFjZw Gh7Z6lKvEmRsmP92cD6WTfwIpW+15Qgn9T6nDIULW85lgkb3TjDch7NqgW72VJwsd6IX HqLHN38CWTX3z+xQyUs6HmqrJUrjFGBKqr0ONb9KPGgiUWFTb4Mpywc8TVoaHVKMBGsN frhA== X-Gm-Message-State: AOJu0Yzwm7Xwzpw6t/twecamxrt/jwx2OwuwciNvkNTH32rIlC9wZ0vV MqB5p1/7VR/kJu7/SG+awvghSGakZEeeL53L2pnHS/AT2Df4pYDRq8VESklKT3u95rbsE25LUO3 fBXld0COOmcDvCwpD8GtKxYcjbjLAJ47Bv3M= X-Google-Smtp-Source: AGHT+IF8Rd8GIK7mZ/q8v/pFtsINrt+qJo0xQ98//jnRohS1duaVakB4r8bZ7V0wO5KcdW4BB6JCB3rCIoWMrKKk0Qg= X-Received: by 2002:a05:6a20:d90a:b0:19e:cd5d:8903 with SMTP id jd10-20020a056a20d90a00b0019ecd5d8903mr3763194pzb.24.1707929296910; Wed, 14 Feb 2024 08:48:16 -0800 (PST) MIME-Version: 1.0 References: <20240214015515.1027-1-ovchinnikov.dmitrii@gmail.com> <5d765e09-0037-407c-b21d-1ff3531c2185@gmail.com> In-Reply-To: <5d765e09-0037-407c-b21d-1ff3531c2185@gmail.com> From: Dmitrii Ovchinnikov Date: Wed, 14 Feb 2024 17:48:05 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/9] libavutil: add hwcontext_amf. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >>AVAMFDeviceContextInternal *internal. Can't say if this is needed here >>at all or not. I have separated AVAMFDeviceContextInternal into a separate structure, since it is also used in the decoder and encoder, even when hwaccel amf is not used >>These should probably take a AVAMFDeviceContext pointer. they are also used from the decoder and encoder for initialization, even when hwaccel amf is not used I did this to avoid massive code duplication. If you have any thoughts on how to improve this, it would be great. For the rest of the comments, everything is clear, I will correct and send an updated version. -- Sincerely, Ovchinnikov D.A. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".