From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B100E43FDB for ; Wed, 23 Nov 2022 14:44:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FA2868B1A0; Wed, 23 Nov 2022 16:44:43 +0200 (EET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4110B689B6B for ; Wed, 23 Nov 2022 16:44:36 +0200 (EET) Received: by mail-pg1-f180.google.com with SMTP id r18so16901405pgr.12 for ; Wed, 23 Nov 2022 06:44:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=oWArxPYMNANEP72Zl8UI2pm/O7X45M+u+GBANYTunps=; b=hb1nj3hp5M5ur0dalq85qI4k50plD7OsYN6px6f+AefC18OyFKvwtxAeM1eBoO4LtG p/UalzK51R7wR76aYbKbETQSLiwLVXZ8mFmhNpMadb9TOp6BHQsutQALQyMD260cilb2 M9/oRd5KoT6LlYWnBMfCSV8ZJoODM52ybvZ1ebx5ozAt05rbBAQIxsEsF8jWzcocwB7A +6Vc5mXgkqbnXBUIi3Xzs9VBcOneV+3alxjIqcrsCedPY6I8ia76RiyBEjNpST4IU8R3 fsY/OUTrRvffnlDWCxyQphDjChbqB0bWc06Ht3qXx8Z5wV9mvGVoat7hAtR+9kpfdh6y 0yrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oWArxPYMNANEP72Zl8UI2pm/O7X45M+u+GBANYTunps=; b=zqsRRAhT66U1uTmiIW90Utdr1yFO83YJe97w2Dx8mGP7fyWnehbindzxa8Pph8qGv0 XSyAdwKFf6Sp/53s1Olwy1sgfUxGRrKlWh7Cq/lTQDtVzO/VlKyYsy5rAVDX/eRTCwdL XLmwzJAktopWRyTWtrLcIY+fmkRHMI90fxUrK/mT/UM2NsEP1N7ecGV9aku52H2TvGwQ deEojKrmnJPdzi1WP0LylWTmrsI7s0TWBbkHr6g3ktPo8lrEV+IQEpHt70GYveB2C4Mj Rt65tysXmaMila6EObZmOWe+GzL5qLmXlrUDHvB3ZFZU1W9iaKIK9u6eJyOqlbHJ8NlR kPkw== X-Gm-Message-State: ANoB5pmgtYdfcbz3eHyLbELM6Vo+Ssm5hJFzesB9B0S5+pMBsKofDpk7 OwZHX8Odi5bToqbOhz9e/XqwWAAzkt8VzpxFNSiDHf51fFP0jA== X-Google-Smtp-Source: AA0mqf7vc1ok1m6DOJhCtCAELy4OipeqXgUlGWvwy1b91so/LAAI8TNKYYCMU1gsVEmNkE/Ddm6QtcZNUid0R2tN7wU= X-Received: by 2002:a63:2001:0:b0:477:b0d0:bbee with SMTP id g1-20020a632001000000b00477b0d0bbeemr5469867pgg.51.1669214673959; Wed, 23 Nov 2022 06:44:33 -0800 (PST) MIME-Version: 1.0 References: <20221104141336.1812-1-ovchinnikov.dmitrii@gmail.com> <20221104141336.1812-2-ovchinnikov.dmitrii@gmail.com> <20221104153422.GP1814017@pb2> In-Reply-To: <20221104153422.GP1814017@pb2> From: Dmitrii Ovchinnikov Date: Wed, 23 Nov 2022 15:44:25 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [crop support for matroska demuxer, V4 2/3] libavcodec: Public code to support container crop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >>The types seems mismatching The reason for the mismatch of types is that I left the int type according to the comments : " James Almer IMO the AVFrame ones should have not been size_t to begin with, not just because the actual dimensions you'll apply them to are int, but because these fields are not arch dependent or meant for the size of some object in memory. " It seems that performing casts would not be a good idea. Should I make crop fields size_t type as in AVFrame? Or is there a more correct way? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".