From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4D34E42CFC for ; Fri, 3 Jun 2022 19:48:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 046AF68B7B3; Fri, 3 Jun 2022 22:48:16 +0300 (EEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 85F6368B6C8 for ; Fri, 3 Jun 2022 22:48:09 +0300 (EEST) Received: by mail-wr1-f46.google.com with SMTP id x17so11647237wrg.6 for ; Fri, 03 Jun 2022 12:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=BAfRJtK8yTsH8fBLZV5mgRvFXWkxjheMB7o9Gtu9Eg0=; b=mD61WfG2yQ3Duo3Kjpw5at+LCGtkFQXeQBSs8QgTdZypWTdt90K5EGG3jwQZ5SYCqG 8bE7Yf7XCUAGByCndEWwVrRj0yGvqQxwqnsrSioKT3ZvKCGkz7c26peX3X1nA1fvVvri QloEsp2orjjjvPM7SgzH3FL1H+W8zomi8yOaIqOaD1s5R5qNsQ43RBCu2iyCJV85YiLI naOy/6evNLBDdf3f+ewLuToBE/BWnQjRh1rrcvanV4/md6ALLoTxfjCpSiGwZ3f/eyCt BgBblTwdH+ttfT/oPLRE1LUORNANh3MYPjb3ZQ+Ojcodan8iSo74k15GVujtggVdeiln tEKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=BAfRJtK8yTsH8fBLZV5mgRvFXWkxjheMB7o9Gtu9Eg0=; b=IWE1wsxs0fPVljHdR5FlB7WaFDjzMT4vqKXYKjryMP6Svhl90Pkr0GUs9/DD1h546N 62qSy6twt2G9qANdOnxg6uUr3R62LqCB8dKFj/U/b945MM+MRyeTD+Dr9TRfvf71ydbx sle0Fo+XFlT1nJeayW10QjJvw/dNgvkYc/myPvb7Y7mi1PwVQcrHohaNtWtUuuhnGe6R qrV/zSeqeFV6k98Y7xjkFvWWOZJIrYoHYPYdKKLXRkWeWpWYZWz0vh2v8UlIgCV86Vmv xzFBX36nF51BuF8sB/lB0JMaQ7PB61vPMp49zbm0qxYYHtH/l0opOPa2bhtqY/fQ2+9O nZOQ== X-Gm-Message-State: AOAM533wag1Sw0c8XBD8+4piMQ5k0XO5xbV+2TLKWLlw14v9n/zysUtf vyq5GGFnbEZDccS5p38XXzfF1dl+NdF/iHKqaCvKIzc54yR1lA== X-Google-Smtp-Source: ABdhPJwHG2xIPUGtZRrdiC9tgpqrcrdQ4zPgHjMF0aFbBMk7nmWLJ1g3nyhXP2dA6ZW8smuCLMNoS4Viik7y1uApl58= X-Received: by 2002:a05:6000:1186:b0:210:413:aa6b with SMTP id g6-20020a056000118600b002100413aa6bmr9598217wrx.383.1654285688807; Fri, 03 Jun 2022 12:48:08 -0700 (PDT) MIME-Version: 1.0 References: <20220603131156.1772629-1-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Fri, 3 Jun 2022 21:47:56 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op vr 3 jun. 2022 om 19:11 schreef Andreas Rheinhardt : > > You are not checking this; this could lead to uninitialized values being > used in flac_parse_block_header() below. > Yes, indeed, thank you. Interestingly enough, I copied this bit directly from mov_read_dfla in mov.c, so I'll send a patch for that as well. > > Is there an official spec for this? > Not that I know of, but as I was looking at the file the with a hex editor dfLa stood out as recognizable, as the MP4 spec uses it as well (as Jan already commented). Therefore I copied most of the code from mov_read_dfla, with some additions/changes as it is used in a different context here of course. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".