From: Martijn van Beurden <mvanb1@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing
Date: Fri, 3 Jun 2022 21:47:56 +0200
Message-ID: <CADQbU6_xW0W+09kCUYksPz8A-QACP_7g0f2TLvjXUvSMfG9p6A@mail.gmail.com> (raw)
In-Reply-To: <DB6PR0101MB22141C763CCBAC59900933F38FA19@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
Op vr 3 jun. 2022 om 19:11 schreef Andreas Rheinhardt
<andreas.rheinhardt@outlook.com>:
>
> You are not checking this; this could lead to uninitialized values being
> used in flac_parse_block_header() below.
>
Yes, indeed, thank you. Interestingly enough, I copied this bit
directly from mov_read_dfla in mov.c, so I'll send a patch for that as
well.
>
> Is there an official spec for this?
>
Not that I know of, but as I was looking at the file the with a hex
editor dfLa stood out as recognizable, as the MP4 spec uses it as well
(as Jan already commented). Therefore I copied most of the code from
mov_read_dfla, with some additions/changes as it is used in a
different context here of course.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-06-03 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 13:11 Martijn van Beurden
2022-06-03 13:18 ` Paul B Mahol
2022-06-03 17:10 ` Andreas Rheinhardt
2022-06-03 18:45 ` Jan Ekström
2022-06-03 19:47 ` Martijn van Beurden [this message]
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 1/2] " Martijn van Beurden
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: prevent potential use of uninitialized value Martijn van Beurden
2022-06-11 7:32 ` [FFmpeg-devel] [PATCH v3 " Martijn van Beurden
2022-06-11 8:50 ` Paul B Mahol
2022-06-07 9:05 ` [FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing Anton Khirnov
2022-06-11 7:31 ` [FFmpeg-devel] [PATCH v3 " Martijn van Beurden
2022-07-05 11:42 ` Martijn van Beurden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADQbU6_xW0W+09kCUYksPz8A-QACP_7g0f2TLvjXUvSMfG9p6A@mail.gmail.com \
--to=mvanb1@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git