From: Martijn van Beurden <mvanb1@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding
Date: Thu, 15 Sep 2022 21:52:47 +0200
Message-ID: <CADQbU6_PvSqAnU8eebTZXO_n_B1d4Ck-SYG8VYz5ej6ve59R-A@mail.gmail.com> (raw)
In-Reply-To: <GV1P250MB073700A9C79ACDF2549B08298F499@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Op do 15 sep. 2022 om 20:20 schreef Andreas Rheinhardt <
andreas.rheinhardt@outlook.com>:
> (In any case, I don't get why there are two samples: The flac decoder is
> intra-only, so if you made the samples so that one of the frames had a
> wasted bit, you could test all the codepaths that two samples test. And
> it would even have the advantage that it tests what happens when it
> swiches from >0 wasted bits to 0 wasted bits to >0 wasted bits and back.)
>
It seemed easier for anyone triggering a problem with wasted bits to figure
where the problem came from. A problem in the second file but not in the
first is quite certain to be related to the wasted bits handling. But
perhaps the probability of this happening is so low that it is not worth
increasing the size of the fate sample collection. I'll create a new file
and ask for a replacement.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-15 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 16:21 [FFmpeg-devel] [PATCH v5 0/3] 32bps FLAC patches Martijn van Beurden
2022-09-15 16:21 ` [FFmpeg-devel] [PATCH v5 1/3] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM Martijn van Beurden
2022-09-15 16:21 ` [FFmpeg-devel] [PATCH v5 2/3] libavcodec/flacenc: Implement encoding " Martijn van Beurden
2022-09-15 16:21 ` [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding Martijn van Beurden
2022-09-15 16:58 ` Andreas Rheinhardt
2022-09-15 17:43 ` Martijn van Beurden
2022-09-15 18:19 ` Andreas Rheinhardt
2022-09-15 19:52 ` Martijn van Beurden [this message]
2022-09-16 20:12 ` Martijn van Beurden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADQbU6_PvSqAnU8eebTZXO_n_B1d4Ck-SYG8VYz5ej6ve59R-A@mail.gmail.com \
--to=mvanb1@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git