From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 80E9E44E0A for ; Fri, 25 Nov 2022 16:39:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DE1368BC29; Fri, 25 Nov 2022 18:39:10 +0200 (EET) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 100C968B9C1 for ; Fri, 25 Nov 2022 18:39:03 +0200 (EET) Received: by mail-lj1-f175.google.com with SMTP id q7so5745551ljp.9 for ; Fri, 25 Nov 2022 08:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=+JF2iWBiLrR6SRNZBRzsrAbqS/Rz1Zjrnsjm/wgekDY=; b=G0TSGjdnRkJcLhMtXkVVathkM2sFeTfYs8C57EUIOwoTnW+BXyMvEEWlMYPJkK3QWp sn4TSakCgohNfGsg8eE5R01w7cbvHg8AKTjit7gWMYS48770bususi9/DhBM7p+YZ5OM zlFQX1A+ZnsxhHkPzKZA1743+vDO1qXo/xo852C2fR+32m7e3Ra6RQrPEbFJrHbvVBZ9 vdgiA3PDHO03zWqPbJ5jGLSFgWgnLUFaJcBBe8//GYoaeh8fl00VHI3oeEqnet4FkEQY ZrQqYjIpbBTiY8NrZrl2L68Xc+WQ9JqJbTrcridBSb8Ucz6Jypw5MKANXUmVt71sdYQW 1kqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+JF2iWBiLrR6SRNZBRzsrAbqS/Rz1Zjrnsjm/wgekDY=; b=khltCWlkO2tzXxOm5V4DfJkxRNrCjzha/kvyTVue2sOb5cYS0AZfRlUiItv/XQV0Jj /WFUw0Yr43K05yAt43EDygKsL1palS4MreOLW3dV/3exAWc1h2LWIaKJShIao7XT5FTk XhtlGBIcnQcCHDs1We7uy67IGgFwMhVkw+jCdNPg+WAJqd7x5Sw8MQ9jXdcr4KEw4UBj ISpCo6WI/qGr01edmjTxiaZttM7MNMvWVc63XaUe+1Ymm0kUCnm0PwS7NqPOS2z/Fb9d /2bzXph0q7lfr0HcqY5M5j1yu8USoqwqacyXWjU+JzaLLeScS4p9Mt7t+61BXAV1EycB DhBA== X-Gm-Message-State: ANoB5pkmN+qEJawTiNislJyAvhXbjYkw3KMCj5y27wu7TlDgWzWc8c9B zbQMv67rwcy7Tp1yBd29cvnnq8DhEqJcXh5kapHosTVWRAA= X-Google-Smtp-Source: AA0mqf6Wa36c9mwDKBDWirukRU5V/hnN5l0rK2S+jtcEUXZMvKPhyEvpXJ6nYl2KtRSG4PnBAkfxJHpLKTT0XmLuIs8= X-Received: by 2002:a2e:9e52:0:b0:277:75bb:42b3 with SMTP id g18-20020a2e9e52000000b0027775bb42b3mr13532328ljk.409.1669394341515; Fri, 25 Nov 2022 08:39:01 -0800 (PST) MIME-Version: 1.0 References: <20221011172437.36211-1-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Fri, 25 Nov 2022 17:38:47 +0100 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op vr 11 nov. 2022 om 22:11 schreef Martijn van Beurden : > > Op vr 28 okt. 2022 om 22:13 schreef Martijn van Beurden : > > > > Op di 11 okt. 2022 om 19:24 schreef Martijn van Beurden : > > > > > > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > > > to create FLAC files containing 32-bit int PCM samples. To > > > keep complexity reasonable, the choice was made to limit residuals > > > to 32-bit integers, which the encoder must make sure of. In case > > > the encoder cannot find any predictor of which the residuals fit > > > this limit, it must default to using a verbatim subframe. Tests have > > > shown that this does not happen often (<0.1% of subframes on a > > > music corpus of various styles). See also discussion here: > > > https://github.com/ietf-wg-cellar/flac-specification/pull/148 > > > > > > These two patches implement decoding and encoding following this > > > format. > > > > > > Changes since v1: > > > fix copy-paste error in encoder, several invocations of > > > lpc_encode_choose_datapath used wrong parameters, making FATE fail as > > > compression was less than it should be > > > > > > Changes since v2: > > > Rebased decoder part as it didn't apply anymore > > > > > > Changes since v3: > > > Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) > > > and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) > > > > > > Changes since v4: > > > Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits > > > for 33bps subframe. Add fate test > > > > > > Changes since v5: > > > Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced > > > -strict -2 with -strict experimental in fate and encoder warning. > > > > > > Changes since v6: > > > Deduplicated function bodies with preprocessor macros in both > > > encoder and decoder, declared variables in loop body where possible > > > and changed ff_ctz to ff_ctzll where necessary > > > > > > Martijn van Beurden (3): > > > libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM > > > libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM > > > fate/flac: Add test of 32 bps encoding/decoding > > > > > > libavcodec/flac.c | 4 +- > > > libavcodec/flacdec.c | 218 ++++++++++++++++-- > > > libavcodec/flacenc.c | 480 +++++++++++++++++++++++++++++++--------- > > > libavcodec/get_bits.h | 12 + > > > libavcodec/mathops.h | 9 + > > > libavcodec/put_bits.h | 7 + > > > libavcodec/put_golomb.h | 14 -- > > > tests/fate/flac.mak | 4 + > > > 8 files changed, 602 insertions(+), 146 deletions(-) > > > > > > > Hi all, > > > > With this email, I would like to renew the attention of the mailing > > list for these patches. > > > > Kind regards, Martijn van Beurden > > Ping Ping _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".