From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 25B27427DC for ; Wed, 30 Mar 2022 17:55:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3705A68B325; Wed, 30 Mar 2022 20:55:11 +0300 (EEST) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02C2068B309 for ; Wed, 30 Mar 2022 20:55:04 +0300 (EEST) Received: by mail-wm1-f51.google.com with SMTP id n63-20020a1c2742000000b0038d0c31db6eso479917wmn.1 for ; Wed, 30 Mar 2022 10:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=sQju0ysqvsYg1G9hXgENwOEDAQ5lqmCDPZtPSEtfais=; b=LCAYnk574TEgkQgveVgDu+fQfIQIRiAfFMXwmmLprgka5Ph5m8CTI/6jjoe4960ALf 0SNesC4BDE2Ah255P/BzMWG2XI0IHx/Zks1BVDM8qDNWBRV/QZSKLoL2B2NLOZ4CsZ91 J/9rXd2CEF7mWvKKXrcLWlVf5XcS50RDZVPnEcNIDcMUQ+tHW9I+gtM9KpLKDhyBFWH8 /HCEwtVvTbkWEArDO7qJ5/W5KOhEKCaMlePjlfJG9ki9t1wwRJAC5nAI89146+bCKImg p3wW3X/xSg5zv/voeKNDnxL8ESRdJxhp+JqPQ06YaWhWPCCctL63PyQ75oIPzly3v6si BMvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=sQju0ysqvsYg1G9hXgENwOEDAQ5lqmCDPZtPSEtfais=; b=U1fPA5Ndew/iH1/O8ANxRCd2adSOwV2nTzoKDE+4wbVTAG6DMIKxyMgUlsR1NorAtu tADJEaqfvcjQaZ+UHXBDTOVLhiWDiKs96ZUdKr9sHZ+K2yFD2ACmMwtztCT0e54c6/J+ 8EaNv2gpCJwYFauOkR5G2VGjV6M8RGE2/kKaaA9Y3ObdrjPtZfeEJd8waJZYSy4R0eQb Zle43IVtR8suopRt1TyB56N7X6In2dLNv/qj6e+r2BAs2M7vGnjnmB6jgRQBFMuz14vq /jRRkTIp96WJBg4J1J6cPhDyT/pBJn/VGx8WFkZpBtOmFCZqtRE4QxubD+JC4g+HshKf 6JUg== X-Gm-Message-State: AOAM530wP9nBOphZgA8S7tcrV136vBGit9ahOpl6iZBYAnH+F8E3c9jg mz4skJDF22pTTIe47A4U1oTBXDplkzsmg8kn78WN/BbK X-Google-Smtp-Source: ABdhPJxjkzdXWfmjV1iw4SFErlhCh2YstFJ5KpiexzZ9j0Cmq715LamT9Cl3z0nRHCGZG9MiTTC1HlhS6NRnn3Lwlio= X-Received: by 2002:a7b:c774:0:b0:38c:9f3f:4bdd with SMTP id x20-20020a7bc774000000b0038c9f3f4bddmr744503wmk.28.1648662904232; Wed, 30 Mar 2022 10:55:04 -0700 (PDT) MIME-Version: 1.0 References: <20220327133933.43039-1-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Wed, 30 Mar 2022 19:54:49 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: First of all, thanks for reviewing Op wo 30 mrt. 2022 om 12:42 schreef Andreas Rheinhardt : > Can this happen with real encoders or has this file been specifically > crafted? What is the performance impact of this patch on ordinary files? This file has been crafted. It seems unlikely to occur in the wild, but it is not impossible. Anyway, I found this 'problem' while doing some research for the IETF CELLAR working group, which is in the process of creating an RFC on FLAC. Perhaps I sent in this patch too hastily, on second thought it might be better to fix this in FLAC encoder implementations, of which there are few, instead of FLAC decoders, of which there are many. As the IETF is in the process of amending the FLAC specification anyway, such a provision could very well be included. Sorry for sending this patch in too soon, once more thanks for reviewing this. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".