From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5A0884025A for ; Thu, 20 Jan 2022 21:18:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0FB1668B223; Thu, 20 Jan 2022 23:18:43 +0200 (EET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0AAD268B218 for ; Thu, 20 Jan 2022 23:18:37 +0200 (EET) Received: by mail-wm1-f45.google.com with SMTP id w26so14656265wmi.0 for ; Thu, 20 Jan 2022 13:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=thBmOS6F14SkxY34TMiZLZNaCEPkKN0E0dtIfghBZbg=; b=itBEmMKckoHGQRzK+GiioVHwm7TtVpNQeJ0XgOQJNwfajGTnRKTt3V3Y6d+yIXYCXm OZK0EA4XkXvqd7XQdedf5n0OQVb6WjMxPvHaedhN7ACjAh/q0WDH6x37IUQRwXg/VsAh xOL0kEQ+P9NYG0fImk9Iej3G7Q+E3wWGw72g+Et4pi9uOnJuPjsWaWdp+J6aZZaiFvKx orOKXQUGbNoSjjmyzk/6CWslp5WE/s2xvSNZtBbORxeHhIt5rOVusveBLhSfivA7/HbY MdsCwSbOJb/LaELhVileIHkaIc4K1US2wW197ov6NOjDxJi7qTzn0EZqaXJQbozO97uN Mpjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=thBmOS6F14SkxY34TMiZLZNaCEPkKN0E0dtIfghBZbg=; b=FGJi/B/qvv5F35I0aXsSU4fvZDQkPEq5dNLVS1af3PU6f+jhHHsm4JOpAPZd3RfZRs I40LkmDUK11Gu1a7ShyrMw0jZANjynvy/OG+w3adionwVFZHTOpPGVzGi/Bv1vced//d rDcH9qjpLiX3PxrbAncJuYP0JNPNhUjPSKrhrKEcvbvwYIxielDtE3crZCFN4CfcOF3N Li4dcldawuxn77DxwHtuoImlTzEd4XFRVNMw20Q2JWYZjapxtqujlQ3/smk1kOCLt1ea EKkTaGvlewZC3m6VHM6hJE2Ri+ry5W+8TcUeVtsnG7snrPdHLA4j+wVymSDaGg3vW9c4 +IXw== X-Gm-Message-State: AOAM531HDLj1JHHtmqUgnSJy+a3CSxfEyDvuuQXf0lxw4tXKQWW2J1Xb ceZ9mt1yc9lKDBX6j/+9U5xmQe72bA0yh/d5yHDJXMrZ75I= X-Google-Smtp-Source: ABdhPJxEmON5XL8hcqimcNcZboj2cOrkdTXMDVMY4geeoM8rH+ttMYFKDVpvU0rOLc6JKY4REodv/sQdiqaj++kuENo= X-Received: by 2002:a7b:cf2b:: with SMTP id m11mr10581348wmg.153.1642713516350; Thu, 20 Jan 2022 13:18:36 -0800 (PST) MIME-Version: 1.0 References: <20220120160506.32698-1-anton@khirnov.net> <20220120160506.32698-3-anton@khirnov.net> In-Reply-To: From: Martijn van Beurden Date: Thu, 20 Jan 2022 22:18:22 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavc/encode: pick a sane default for bits_per_raw_sample if it's not set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op do 20 jan. 2022 om 19:58 schreef Martijn van Beurden : > This creates a new regression: now 24-bit WAV files are converted to > 32-bit WavPack files. I think I found the cause of the problem though: the > issue is that wavpack uses sample format s32p and 24-bit wav files use s32. > Therefore, a aresample filter is auto-inserted to convert s32p to s32, > which causes ost->filter->graph->is_meta to be false. > Also, I see an abuffer is also added to the filtergraph which too causes ost->filter->graph->is_meta to be false. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".