From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 18CAB43E85 for ; Thu, 15 Sep 2022 17:43:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6414B68BBC9; Thu, 15 Sep 2022 20:43:24 +0300 (EEST) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F59668BB22 for ; Thu, 15 Sep 2022 20:43:18 +0300 (EEST) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-3321c2a8d4cso229790467b3.5 for ; Thu, 15 Sep 2022 10:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=I1JWdoZd9tWyzO0/cobXYDi5I77nmQJ2AZfsvID1WCM=; b=VP4gVupmpm/nxBBpOvUeL4eFt6TrdpjWOmFTcdSNJi/3TJB9ROnURoxf7KnupAmX6N yKm0L0anWo4znghc+kFyxrI3FDxqfesskC0VBQ6ssOzlE6e9gOn9y002nm3xTbSGHQmT PzwPK2tRuwcOz3IAA63ohTjwDb9VfhHIpWQH5Nrb8Wu/0DWNIGYjPupmlJvYGfJTvKOt V2g8wBau9Zm9puYJ2Wc3Q+isWIYw5mDWrBqKYclSM5sc6aViXjYO64kA1H2PbS6AUqNE cL7aIM/v9lsNuJ7n7YONDk6jugdA3fOohbqFuFBJ2s9YOJqO5OjCMinFF+f8ct7+9T2Y y/xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=I1JWdoZd9tWyzO0/cobXYDi5I77nmQJ2AZfsvID1WCM=; b=6qpqvwB00jwKoO/hpjIjF7IYA3bjJYrubOkvxQCwpv67RCR1NhoDNe1fTLyicXduvg dHOxbp75mvhOyxT7FyYc83vymZSdpVLdIP5EaTR+zbw8pXzFr72R4V+VLBQaD353Cxdd /1qOTT6ez2R1M0tB/DdJ+ihPYNY+8roswPJTWtusSzYlgusjB8j3Tj0Ibus3foCYH4NS zuGUAc2QACnJR4H9gD0AZs+4rs4neQlJ1JFmy+jlMbDZFOpEgnlJkIMxltGolLLZ9aI2 r6PqP89q+96kKH6nXC5Ci+8bwjqkxRTxX/RwhhV6HMcFyAEVnuS4r/Ls0hAuUvks3r0K +tkw== X-Gm-Message-State: ACrzQf2ZFjvcr8E4f11WsnO1qHgDonroiDRSw7FaYtEtFrtOprpgcyyU RdW2fJobslUmkPqkisMGklYE2y75pZVAo42wvoRZobrAswBOSw== X-Google-Smtp-Source: AMsMyM5y5cvkXmKEw1cL9wb67HgvlmZKHNRNy34WvXl8qW/o9WV32KHivOOo9OTLwXlgRUN1fF+oHxmT4t1gD2RYKv4= X-Received: by 2002:a81:7c45:0:b0:349:bc24:9591 with SMTP id x66-20020a817c45000000b00349bc249591mr823661ywc.211.1663263796875; Thu, 15 Sep 2022 10:43:16 -0700 (PDT) MIME-Version: 1.0 References: <20220915162145.2284957-1-mvanb1@gmail.com> <20220915162145.2284957-4-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Thu, 15 Sep 2022 19:43:03 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op do 15 sep. 2022 om 18:58 schreef Andreas Rheinhardt < andreas.rheinhardt@outlook.com>: > Martijn van Beurden: > > --- > > tests/fate/flac.mak | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak > > index 115cc965e1..4db28b1e1d 100644 > > --- a/tests/fate/flac.mak > > +++ b/tests/fate/flac.mak > > @@ -6,6 +6,8 @@ FATE_FLAC += fate-flac-16-chmode-indep > \ > > fate-flac-16-lpc-cholesky > \ > > fate-flac-16-lpc-levinson > \ > > fate-flac-24-comp-8 > \ > > + fate-flac-32 > \ > > + fate-flac-32-wasted-bits > \ > > fate-flac-rice-params > \ > > > > fate-flac-16-chmode-%: OPTS = -ch_mode $(@:fate-flac-16-chmode-%=%) > > @@ -20,6 +22,13 @@ fate-flac-24-comp-%: OPTS = -compression_level > $(@:fate-flac-24-comp-%=%) > > fate-flac-24-%: REF = > $(SAMPLES)/audio-reference/divertimenti_2ch_96kHz_s24.wav > > fate-flac-24-%: CMD = enc_dec_pcm flac wav s24le $(subst > $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac $(OPTS) > > > > + > > +fate-flac-32: REF = $(SAMPLES)/audio-reference/drums_2ch_44kHz_s32.wav > > +fate-flac-32: CMD = enc_dec_pcm flac wav s32le $(subst > $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac -strict -2 > > We already have 32bit samples in the fate-suite, namely > wavpack/lossless/32bit_int_partial.wv. Why don't you use these? > (Anyway, don't hardcode the numerical value of 'experimental'.) > I wasn't sure that was possible. If for example the build is configured to leave wavpack out that wouldn't work. Or is it assumed that fate is only run with a ffmpeg build configured with default and some additions but nothing default left out? Considering the strict value, I guess I should also change the help text then? Now it reads: encoding as 24 bits-per-sample, more is considered experimental. Add -strict -2 if you want to encode more than 24 bits-per-sample _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".