Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

From: Martijn van Beurden <mvanb1@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM
Date: Wed, 14 Sep 2022 17:21:54 +0200
Message-ID: <CADQbU697hrvWeUxyKfqJgOXwxpq0nUSJ-vupbA9qrrR08KNhhg@mail.gmail.com> (raw)
In-Reply-To: <GV1P250MB073709D6FFD01F5CFF122A518F469@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

Op wo 14 sep. 2022 om 15:03 schreef Andreas Rheinhardt <
andreas.rheinhardt@outlook.com>:

> > --- a/libavcodec/flacdec.c
> > +++ b/libavcodec/flacdec.c
> > @@ -64,6 +64,9 @@ typedef struct FLACContext {
> >      int32_t *decoded[FLAC_MAX_CHANNELS];    ///< decoded samples
> >      uint8_t *decoded_buffer;
> >      unsigned int decoded_buffer_size;
> > +    int64_t *decoded_33bps;                  ///< decoded samples for a
> 33 bps subframe
> > +    uint8_t *decoded_buffer_33bps;
>
> Why do you need a new buffer here instead of just reusing decoded_buffer?
>
>
I don't follow, do you mean I could have decoded_33bps use decoded_buffer
too? Wouldn't that kind of aliasing lead to problems?

> > +        av_fast_malloc(&s->decoded_buffer_33bps,
> &s->decoded_buffer_size_33bps, buf_size);
> > +        if (!s->decoded_buffer)
>
> You are checking the wrong variable.
>
>
I'll fix that, thanks!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".