From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2BF70445AE for ; Fri, 16 Sep 2022 20:12:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02CA468BC38; Fri, 16 Sep 2022 23:12:41 +0300 (EEST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AFBC368BBE1 for ; Fri, 16 Sep 2022 23:12:34 +0300 (EEST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-3452214cec6so272546027b3.1 for ; Fri, 16 Sep 2022 13:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=3QD5DBUD/cO88dNRBm76bUH4a/+i5pEy1tpB84g5iYU=; b=Wc0/Vg1s0bpACQ8O0oTbW/bGdUfh0o17YXGySws0/ZZGBTF+lPayWTCru0r6bQEHsk mniSJSssf4DET8xqjkUEvSmlx63yBzPUswb7130kn2BsEBgXVyUlFulxzF6jxdIet0oZ JEUJrlXMzehAIAwLZ907bx6y227oAu6FzftaxZ4lUPjM5YMNYO8mVAa/yYhxPTwwldER GMvWWmt+bO2Qs5NQooMWM+xDntj0ptYCuIOMf4CApAlxgnvA2GqDU6RTlKfX6SjgVE32 rM5fNJzxXa5lzz4BXAyQ0DpQZ6ZEYt/luEcOQL7unl1vLdWqTqWkfXU07uEyci+e6Pcg M0rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=3QD5DBUD/cO88dNRBm76bUH4a/+i5pEy1tpB84g5iYU=; b=7wChlj/j3zRx0rRt5Nkywzbw2ykrAj7ipUJT3RAZyX6IevisZvKqqqEABQSV0RWfI6 bZstEvm5Cdrtbq5ksV4Annvvsfs9z7aIRbD9Phq3WIFPurHqX3vNCo9XLJ3Hq+RroluH ad3GICt95njvSTHFH+TzGV9tfv0zPpaGablk7141vXCVlR2mw7jqW1CsU2vWBuUF2aAs H2mXPs+Z0k4cavvEbKTlMCIyDrdInmFgmj3Bg9gA23dmwjE6DDxuMiNnAi4xU2r+MoeK GE88k8RDuAeMG3rjR0oQCu+7Vn/IRzqLTNABauQOVgGg67xwl8HR2O5uEKcRwfdCdb8s zMAg== X-Gm-Message-State: ACrzQf221155iBv1T+NhZLsQTP113l4i2qugF+UACXRyiY9bOizt4RPn n8WJCz49VtNpdVyVBU6pxqqKSsi9kH56XkEp4LaxafImYNPDuA== X-Google-Smtp-Source: AMsMyM71jhaRY0RpTf+tpNfS6E4UwAdnLPmHPOcirLMtr+qXgfjym8SKy5IYHk8W0Mu+nNyo4nYIbQKkd2v/HJZy7rY= X-Received: by 2002:a81:4689:0:b0:328:c838:9494 with SMTP id t131-20020a814689000000b00328c8389494mr5877659ywa.334.1663359153067; Fri, 16 Sep 2022 13:12:33 -0700 (PDT) MIME-Version: 1.0 References: <20220915162145.2284957-1-mvanb1@gmail.com> <20220915162145.2284957-4-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Fri, 16 Sep 2022 22:12:20 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op do 15 sep. 2022 om 21:52 schreef Martijn van Beurden : > Op do 15 sep. 2022 om 20:20 schreef Andreas Rheinhardt < > andreas.rheinhardt@outlook.com>: > >> (In any case, I don't get why there are two samples: The flac decoder is >> intra-only, so if you made the samples so that one of the frames had a >> wasted bit, you could test all the codepaths that two samples test. And >> it would even have the advantage that it tests what happens when it >> swiches from >0 wasted bits to 0 wasted bits to >0 wasted bits and back.) >> > > It seemed easier for anyone triggering a problem with wasted bits to > figure where the problem came from. A problem in the second file but not in > the first is quite certain to be related to the wasted bits handling. But > perhaps the probability of this happening is so low that it is not worth > increasing the size of the fate sample collection. I'll create a new file > and ask for a replacement. > Files have been replaced, there is now one file for this test with varying levels of wasted bits. At the end it also has a differing number of wasted bits between the left and right channel. In other decoders this has been a problem in the past. It now changes 0-0, 1-1, 0-0, 1-1, 3-2, 2-3, where each pair is the number of wasted bits for the left and right channel. I'll send new patches in a moment. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".