From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 88CAA44169 for ; Fri, 28 Oct 2022 20:14:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B8C168BCB2; Fri, 28 Oct 2022 23:13:59 +0300 (EEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2FCF668BBE6 for ; Fri, 28 Oct 2022 23:13:53 +0300 (EEST) Received: by mail-lf1-f45.google.com with SMTP id r14so10055377lfm.2 for ; Fri, 28 Oct 2022 13:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=IZ2Iei8xAOobUHtA4LVh0J320nqEYCTLZiPOjm0fysI=; b=BwT2CT8316YcnRVTbEEG6374Go517eVJqpUZs/1/KRdCVmLzKeOUoRLs3OIuT+pa0r dMo/TZ5q9Lv4wEJvmzdpj6HP9s9CfJc+5bKMGOSGeK2o1D3XvYYhDWYZFmSmuRG1Cmgg ppj6cHm6QkVe0UxYvSfupNic29ZOvwrA4jV1JKF4S8OwCXdH8AXklZw6geC035w6t4gm xJVLwgh7pcZHehVtIkDznJe+cF/LiUwPjxmQio8e5Pey8yD1Oo9vpQH6waQ8NRIRariI s65zKHDJDeaXNR7qM/3ken29p3vBI2/8VB7PxqXt64w4wbxT3Ae1selpSr1cVouXDKOV mYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IZ2Iei8xAOobUHtA4LVh0J320nqEYCTLZiPOjm0fysI=; b=v+MrTHjzRa6EKm4BlbnBBKv1ZWJpHv1vD+CgfLCYOxz8ze+yCJOeXomV6PJROaAJae iRYX7LGeQK/rcgp9wzctOCQivyplJRKEf3QTmQzIAqo/XSgWMa3bXSYFl9YurmNOkiwL jzdjWoGIVGh9n2UhrhvH/Yzxu8cHNmAlQ3npMXiRbigvU6eimEbiAephGmAbE21z1IAH VuC4apxqxHpfIr8b4O9xqU+jTLKoH5s1A4dqADA9SptpRLEJ++oQV68D4px4JgLLvKl0 jBjLVIyJP3O42m3KudFQ7aATJqJfk2WITGQqzXQjcNgZmfrGUZC4nfAsgm9Z4/MpcZtW QhqA== X-Gm-Message-State: ACrzQf3yvysBMYlKvMQAk5SjESbkmvG8JH88t1v+svajiESuBKx5E6Gt 6gjbezqWWEmrNyKqYDt4K+HTd8F3NqQUEygKoIw9eG9E X-Google-Smtp-Source: AMsMyM6E+LEVVEzC7/uoMuvLmsgWLcrJERrQVbCY4VQq0ung4U5ExXXlsCwePQRW+3eX49EI8Y31u6qcqE9LYnBGP/M= X-Received: by 2002:ac2:5928:0:b0:4a2:2819:4fb2 with SMTP id v8-20020ac25928000000b004a228194fb2mr359765lfi.183.1666988032097; Fri, 28 Oct 2022 13:13:52 -0700 (PDT) MIME-Version: 1.0 References: <20221011172437.36211-1-mvanb1@gmail.com> In-Reply-To: <20221011172437.36211-1-mvanb1@gmail.com> From: Martijn van Beurden Date: Fri, 28 Oct 2022 22:13:40 +0200 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op di 11 okt. 2022 om 19:24 schreef Martijn van Beurden : > > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integers, which the encoder must make sure of. In case > the encoder cannot find any predictor of which the residuals fit > this limit, it must default to using a verbatim subframe. Tests have > shown that this does not happen often (<0.1% of subframes on a > music corpus of various styles). See also discussion here: > https://github.com/ietf-wg-cellar/flac-specification/pull/148 > > These two patches implement decoding and encoding following this > format. > > Changes since v1: > fix copy-paste error in encoder, several invocations of > lpc_encode_choose_datapath used wrong parameters, making FATE fail as > compression was less than it should be > > Changes since v2: > Rebased decoder part as it didn't apply anymore > > Changes since v3: > Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) > and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) > > Changes since v4: > Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits > for 33bps subframe. Add fate test > > Changes since v5: > Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced > -strict -2 with -strict experimental in fate and encoder warning. > > Changes since v6: > Deduplicated function bodies with preprocessor macros in both > encoder and decoder, declared variables in loop body where possible > and changed ff_ctz to ff_ctzll where necessary > > Martijn van Beurden (3): > libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM > libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM > fate/flac: Add test of 32 bps encoding/decoding > > libavcodec/flac.c | 4 +- > libavcodec/flacdec.c | 218 ++++++++++++++++-- > libavcodec/flacenc.c | 480 +++++++++++++++++++++++++++++++--------- > libavcodec/get_bits.h | 12 + > libavcodec/mathops.h | 9 + > libavcodec/put_bits.h | 7 + > libavcodec/put_golomb.h | 14 -- > tests/fate/flac.mak | 4 + > 8 files changed, 602 insertions(+), 146 deletions(-) > Hi all, With this email, I would like to renew the attention of the mailing list for these patches. Kind regards, Martijn van Beurden _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".