From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1067406FA for ; Fri, 29 Apr 2022 14:48:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70F2B68B27B; Fri, 29 Apr 2022 17:48:43 +0300 (EEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 449C768A34B for ; Fri, 29 Apr 2022 17:48:37 +0300 (EEST) Received: by mail-wm1-f46.google.com with SMTP id o12-20020a1c4d0c000000b00393fbe2973dso6239251wmh.2 for ; Fri, 29 Apr 2022 07:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=1+0OpcvIMGLZZsvwo8RPDONSXKHvlp9r04nwnob7JPE=; b=YQ57nrbT6nb2HAub3aufNE+GiOBp7gla1cNntYtHXLoMk0GCMcyjWMpXzjp2782OUR JCqSIfyPixAU45y1ZyluG/GWTVLK5G4XEpovUc7b83Vz3G/8XNjEmvtdxiDfjpqWmDfK tCrkcOtikNZv+kTBILAKsDWNKdeAnWop/gITx95L4So9crFvPcxbYoms/oXIld+YHDPh t5SBNl1lrXN8ivkx6FJvF4rl3fzsXB1hFU9UjbrL+DmXXuX3aaj2TDnuCrjXkMQw4DSw jPoRFoLXAhQ1yh5vAbfmv0hXUU7qmNnD20dVhCxWK4dZpenjlkf5laBFbyBeF4U6et3P jexw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=1+0OpcvIMGLZZsvwo8RPDONSXKHvlp9r04nwnob7JPE=; b=Pe1OHMY0GiQPQe93q/XvqncBPd/+7mxlPTemmyRGrLEmNEVXErhOXlRsRtd1M0tt7r 6F7AxWDeLZy8E29U8bunE4kJfkSb7XVGYSEJwk4L+mEouVmuKJlZ6N51z1Q2shlCY41N gA1DD26tEOh3m7OYA60fAaY7Ie8x6eSM8w/w3MC/NabjjeHIlYskniAwIlCTOD5h19Eu c03Yw197liNmqY2U/9lhXTGr5atooQBTpXhc/oQzoSIS8ViG6xwTE1YBmm6OMRgbLOCQ 9L85cvDOlQ3DCvkkqpGjmA1ui94PKCP70qhED/BMAiJl16uhNmYGDho+sP9IL940yvvS wRcQ== X-Gm-Message-State: AOAM533OnI4h9mUPwyU9vHJWtVyVlbMyJjCzKzTdrOXgTuFXjSszP72l PGIW5cjRdzamxWwPaz1EdcHv0TiKoqcfuNIpB4VDKzDm X-Google-Smtp-Source: ABdhPJyxNu0SpwSSd1mY7ibVh+M1dDEtA63z5alR0JUVZtW+/OfpMPU5gUyBI8uIT8p3xwyrqM5x4kwQwoovTlY28XU= X-Received: by 2002:a05:600c:2113:b0:38e:bc71:2b0 with SMTP id u19-20020a05600c211300b0038ebc7102b0mr3468676wml.153.1651243716340; Fri, 29 Apr 2022 07:48:36 -0700 (PDT) MIME-Version: 1.0 References: <20220405133747.318846-1-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Fri, 29 Apr 2022 16:48:23 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op wo 6 apr. 2022 om 09:12 schreef Martijn van Beurden : > > Op di 5 apr. 2022 om 15:37 schreef Martijn van Beurden : > > > > --- > > libavcodec/flacdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c > > index dd6026f9de..cb32d7cae8 100644 > > --- a/libavcodec/flacdec.c > > +++ b/libavcodec/flacdec.c > > @@ -260,7 +260,7 @@ static int decode_residuals(FLACContext *s, int32_t *decoded, int pred_order) > > for (; i < samples; i++) > > *decoded++ = get_sbits_long(&gb, tmp); > > } else { > > - int real_limit = tmp ? (INT_MAX >> tmp) + 2 : INT_MAX; > > + int real_limit = (tmp > 1) ? (INT_MAX >> (tmp - 1)) + 2 : INT_MAX; > > for (; i < samples; i++) { > > int v = get_sr_golomb_flac(&gb, tmp, real_limit, 1); > > if (v == 0x80000000){ > > -- > > 2.30.2 > > > > A file needing this patch to decode properly can be found here: > https://github.com/ktmf01/flac-test-files/blob/main/subset/63%20-%20predictor%20overflow%20check%2C%2024-bit.flac > > Kind regards, Martijn van Beurden Hereby I'd like to once more bring this patch to the attention of the mailinglist. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".