From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8E5D64441E for ; Sun, 11 Dec 2022 13:32:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3929968BDB8; Sun, 11 Dec 2022 15:32:14 +0200 (EET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 39B5268BCCD for ; Sun, 11 Dec 2022 15:32:08 +0200 (EET) Received: by mail-lj1-f169.google.com with SMTP id x11so9802505ljh.7 for ; Sun, 11 Dec 2022 05:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=h7eHskktMQztg+7R49UxsEZG+E2tkBq55dY225eGZNI=; b=pcX564RpNWkGjrBRH1+P7jf4acILJwyScYUnqEREdcpGKxIjljRDwzgIJuDArwKAEg PVeJCHlf0cTaEi1ZD1E0JwdyhOiDurn05q6RU6mh3Nch+C/6Fu5SQmr6mkJAvXaLM9ed Myua+v0b98C4qVO8N3DPdLukjBhQYWo/9z5VJOinvnEwm1kKl7xXk0+Nyoi7+/i/ZtDZ Bk1RywDlyxOviBXWGh99ggqS0JSoZN2Fw52gYS/MwR7y3+iVPjI94OH1Nx71vF9Cxyf2 vXXo8K0ADFWKmlY56T8o+wUSOZbSIrFemwgTEebm+ipZEb2n7iY6VOFc2WMsgv5WhwJW H2qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h7eHskktMQztg+7R49UxsEZG+E2tkBq55dY225eGZNI=; b=0EF5uxAcX7lhvY9MPaLbhhXJJgfa4XYnSDo9NmcZBDqkWGP/ls3U1BCakv2KlsyP33 oMC7Y7Tc97C1HM4M81B0I+U2Xq3MgqpLmiqWGaDzHPru8Nx+dImZpz7SjgR4+3x9wxxP WCbHDsbtO7hgdqLLmjr2eWJzb9aODAA7bLPbZJKQYQFKBL1aPtI5Dn7+avFstcTw7LUo g1e29tkYHg0zQIfQ7NQlmyzb3tNMkEbTKWQbllqYsFqxwMVkRihC4viOHjKS7ieyJkhS JQrk9Q8RtF4smdb6gi5QMP2Mo0KNQgL7WWm011+w+idPj/aTQcOqT6LuR1SQAszXvLgR PHbg== X-Gm-Message-State: ANoB5pkOgFvHVbdkJZRWgCiNzalsU39iaUDwNuDPivxOxfCKyq9QcPku 3KrbBoV+ErxR3+a+G9gW85yF0hpw7rcLtc6msWA= X-Google-Smtp-Source: AA0mqf5nmmnCzv3KpjWaDL37YBxbjl7u+/eUGLBakMNlDreFfG+5egyqK7SeZh4TqwAmahfVF7A97VkHTHD8WeHe+4E= X-Received: by 2002:a2e:865a:0:b0:279:f24b:e68f with SMTP id i26-20020a2e865a000000b00279f24be68fmr6884769ljj.34.1670765526750; Sun, 11 Dec 2022 05:32:06 -0800 (PST) MIME-Version: 1.0 References: <20221011172437.36211-1-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Sun, 11 Dec 2022 14:31:53 +0100 Message-ID: To: Paul B Mahol Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op do 1 dec. 2022 om 13:31 schreef Paul B Mahol : > > On 11/25/22, Paul B Mahol wrote: > > On 10/11/22, Martijn van Beurden wrote: > >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) > >> to create FLAC files containing 32-bit int PCM samples. To > >> keep complexity reasonable, the choice was made to limit residuals > >> to 32-bit integers, which the encoder must make sure of. In case > >> the encoder cannot find any predictor of which the residuals fit > >> this limit, it must default to using a verbatim subframe. Tests have > >> shown that this does not happen often (<0.1% of subframes on a > >> music corpus of various styles). See also discussion here: > >> https://github.com/ietf-wg-cellar/flac-specification/pull/148 > >> > >> These two patches implement decoding and encoding following this > >> format. > >> > >> Changes since v1: > >> fix copy-paste error in encoder, several invocations of > >> lpc_encode_choose_datapath used wrong parameters, making FATE fail as > >> compression was less than it should be > >> > >> Changes since v2: > >> Rebased decoder part as it didn't apply anymore > >> > >> Changes since v3: > >> Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) > >> and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) > >> > >> Changes since v4: > >> Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits > >> for 33bps subframe. Add fate test > >> > >> Changes since v5: > >> Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced > >> -strict -2 with -strict experimental in fate and encoder warning. > >> > >> Changes since v6: > >> Deduplicated function bodies with preprocessor macros in both > >> encoder and decoder, declared variables in loop body where possible > >> and changed ff_ctz to ff_ctzll where necessary > >> > >> Martijn van Beurden (3): > >> libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM > >> libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM > >> fate/flac: Add test of 32 bps encoding/decoding > >> > >> libavcodec/flac.c | 4 +- > >> libavcodec/flacdec.c | 218 ++++++++++++++++-- > >> libavcodec/flacenc.c | 480 +++++++++++++++++++++++++++++++--------- > >> libavcodec/get_bits.h | 12 + > >> libavcodec/mathops.h | 9 + > >> libavcodec/put_bits.h | 7 + > >> libavcodec/put_golomb.h | 14 -- > >> tests/fate/flac.mak | 4 + > >> 8 files changed, 602 insertions(+), 146 deletions(-) > >> > >> -- > >> 2.30.2 > >> > > > > > > > > If this is OK, will apply soon. > > > Last time to say no to this patchset. I haven't had any comments the last few weeks, it still applies against current git and passed FATE. If you could apply it I would be much obliged. Kind regards, Martijn van Beurden _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".