From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3EBD94444C for ; Fri, 11 Nov 2022 21:11:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3967068B17E; Fri, 11 Nov 2022 23:11:51 +0200 (EET) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 82E8B68B149 for ; Fri, 11 Nov 2022 23:11:44 +0200 (EET) Received: by mail-lf1-f46.google.com with SMTP id r12so10068965lfp.1 for ; Fri, 11 Nov 2022 13:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=7A72xxwDeJD5yORbg+Gv1BWQ3gqLXBJB9gaBFdEWctU=; b=SqhySt7ojpf2T9PR8cWgHSX17dlkZsWqPL3QsT0fdpvc08F+FABrmexb4P0tbtyeFP 9jZ/oEuzY5lJ+I7hvJ1QN9eTJv2cBQZ2SX4O8/xs1t8P+1Rr9uF7kU8Mqw6gSrkCVngC AtARQDqhBPw+PVZmvCWkWPzlQZhCHUqvPrkiLzNlyeq6EFLNYQWkxSLRnY08IYHXgrcF JUaY1wGQh+k/bF/rpjAqpex5/Ie6lZ9ev9ojg0QPwlrQJ5AoeVbFGkY7tC/2PQXGbVCa iGEyEW6aLxO3qn4U++siQzZZ+AtqiR8lMemrAf9bxDqXeOVs6cxvZKxHhAY7RxSTx38W KZrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7A72xxwDeJD5yORbg+Gv1BWQ3gqLXBJB9gaBFdEWctU=; b=nZFER4X24IcFBBoM+FaaoEzzQCpbZPoc+GXEqlXEpQRBSEpPY/1/c7litm9Awo4g8L kc8PkkQlszZHCErKP7VEAwf56JrrKBRNCt2aGEYWWEywxm5h6x5olQW93tItxNoDx0C5 qjJh+is+ZDFd6t4hE7G8vI5kD3LgLtj8afP5ZL+vHWJRMrze29vUeVFEPOUKdQ/mPBF9 +dYzbUxjVM9+JDWaq8cW0QtXQPUeLBXc8g5Q9WM82I0owX29IQK3WCvkiLKAPNcjfOO4 UjV7EJCYMR3FgDQv0t055qUvK/GRYrBaDDZ1fscqUwnerwlhRqeORvmOBDyuwgLH0HLJ 41dQ== X-Gm-Message-State: ANoB5plmLlKKFoWKHr6ze4Kc4L1pCo/D9ZZ+/35LtIL9dm6u6TJiGZuq 0h4myV5GOtmAQIoAzrpZ08t5ziMlxABVIyVfM4v7GaaJ X-Google-Smtp-Source: AA0mqf6HxcAVjRbDXajzWRViZqzSJU4ShzXoO2woVTJ7HFxYMWrzU16dLjfAgNdXL9OQebthu34Lo1TMSgH5d8PRck0= X-Received: by 2002:ac2:4e0d:0:b0:49a:d9ae:3038 with SMTP id e13-20020ac24e0d000000b0049ad9ae3038mr1241887lfr.44.1668201103512; Fri, 11 Nov 2022 13:11:43 -0800 (PST) MIME-Version: 1.0 References: <20221011172437.36211-1-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Fri, 11 Nov 2022 22:11:25 +0100 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op vr 28 okt. 2022 om 22:13 schreef Martijn van Beurden : > > Op di 11 okt. 2022 om 19:24 schreef Martijn van Beurden : > > > > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > > to create FLAC files containing 32-bit int PCM samples. To > > keep complexity reasonable, the choice was made to limit residuals > > to 32-bit integers, which the encoder must make sure of. In case > > the encoder cannot find any predictor of which the residuals fit > > this limit, it must default to using a verbatim subframe. Tests have > > shown that this does not happen often (<0.1% of subframes on a > > music corpus of various styles). See also discussion here: > > https://github.com/ietf-wg-cellar/flac-specification/pull/148 > > > > These two patches implement decoding and encoding following this > > format. > > > > Changes since v1: > > fix copy-paste error in encoder, several invocations of > > lpc_encode_choose_datapath used wrong parameters, making FATE fail as > > compression was less than it should be > > > > Changes since v2: > > Rebased decoder part as it didn't apply anymore > > > > Changes since v3: > > Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) > > and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) > > > > Changes since v4: > > Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits > > for 33bps subframe. Add fate test > > > > Changes since v5: > > Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced > > -strict -2 with -strict experimental in fate and encoder warning. > > > > Changes since v6: > > Deduplicated function bodies with preprocessor macros in both > > encoder and decoder, declared variables in loop body where possible > > and changed ff_ctz to ff_ctzll where necessary > > > > Martijn van Beurden (3): > > libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM > > libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM > > fate/flac: Add test of 32 bps encoding/decoding > > > > libavcodec/flac.c | 4 +- > > libavcodec/flacdec.c | 218 ++++++++++++++++-- > > libavcodec/flacenc.c | 480 +++++++++++++++++++++++++++++++--------- > > libavcodec/get_bits.h | 12 + > > libavcodec/mathops.h | 9 + > > libavcodec/put_bits.h | 7 + > > libavcodec/put_golomb.h | 14 -- > > tests/fate/flac.mak | 4 + > > 8 files changed, 602 insertions(+), 146 deletions(-) > > > > Hi all, > > With this email, I would like to renew the attention of the mailing > list for these patches. > > Kind regards, Martijn van Beurden Ping _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".