From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 318F8428AE for ; Tue, 5 Apr 2022 16:26:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 200B068B179; Tue, 5 Apr 2022 19:26:28 +0300 (EEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7EC6A68B0C3 for ; Tue, 5 Apr 2022 19:26:21 +0300 (EEST) Received: by mail-wr1-f42.google.com with SMTP id d29so14089421wra.10 for ; Tue, 05 Apr 2022 09:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=MMEUSiPzyGZZQ503QwujECB6rEw1sSg9KZbP1+LVBAo=; b=ouFKZX33YbcMtdGQlFeEqd5B6dZE3v2TDboTk0S2VpEiRtSqiNhuXQY3HsNBO9ciR3 MTCVeHFKNaIPDiUvuJquOAerXCGD2m5ccKDaNS16kET+Id/V7MLH/P2GY/wE8Z7dlnfo 7W2tpCMTGCdtr0An78zCpFoGrXfHon8+qhk9KD5dYs4lfr0VRX+2YI2oOV2TxuNEupeY 9XEhz6b4DrWqkez2cPc67uNVxnOF50LJyfriI4leSaN860NOuLUAruZRuH0A1I2WTyaw V/lq54A2ikkzzeTPQc7CShJHV+6TYo1ktoAXV7zb9bnXF2NHbf7kbbyxIK/LJe7v3Cl0 ThlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=MMEUSiPzyGZZQ503QwujECB6rEw1sSg9KZbP1+LVBAo=; b=1KEDWPP6tUxIDTYkV60gE2hVZX/FE8421fm7xqdzihxqlN6ECVxspuiQGgQKbCeLXM k9OxbIF1ZZbdf6DwvLmMo63NEQYyjb50mRvFUsmC7WoUMScxY9iQQzjb6aiOUJvlwSLN OG7OZGlAcvt2pncATwaSD4OBX6un9RkuH4uxsqh39RU9+U6M66YUsEb4hX3aG97+IKqZ twnKNqlsoBTJDU2nM/5gcSWa8w8Q3yQhbW5fffRGBFYeZ5Zt9HP3ggtS0Vht5nD3i/+Z ucmpiGHLAPLIrYYVIqr7SLQ+OAQD6s31KMK21s2lcU0ny4gJYE1EBUEiJb5L1L+QMNLC 67ag== X-Gm-Message-State: AOAM5306fGgqGfWk6jq8NvsOVlLaYXTPUps1zztLl7iZHsgbJ9KIv61P C6QxSFKgqIAPJX6DGG7PFLQxid2kDrxCQV0HC/m0KT5O X-Google-Smtp-Source: ABdhPJxt0xMQ+gAyrJT5gidLWO7AGUcTLF5CH8KAr4UwLqpJsnDJuoMMGzV/gh5yFVlZE6pF/iYiEe1M+PJa/JkmiQE= X-Received: by 2002:a05:6000:1687:b0:205:80b7:afca with SMTP id y7-20020a056000168700b0020580b7afcamr3195130wrd.665.1649175980685; Tue, 05 Apr 2022 09:26:20 -0700 (PDT) MIME-Version: 1.0 References: <20220405133747.318846-1-mvanb1@gmail.com> In-Reply-To: From: Martijn van Beurden Date: Tue, 5 Apr 2022 18:26:09 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op di 5 apr. 2022 18:04 schreef Andreas Rheinhardt < andreas.rheinhardt@outlook.com>: > > Wouldn't it be possible to use unsigned for real_limit? > The limit is passed to get_ur_golomb_jpegls which takes int. In that function, the limit is subtracted from, and the function is used by quite a few other codecs, so changing it seems risky. Besides creating a cleaner flacdec.c, it wouldn't achieve much either. For tmp = 0 or tmp = 1, reaching this limit means the file contains a INT_MAX or INT_MAX/2 unary coded, so a single symbol of either 2GiB or 1GiB in size. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".