From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2088240300 for ; Mon, 20 Dec 2021 11:25:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6D3B68AE33; Mon, 20 Dec 2021 13:25:39 +0200 (EET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4CFDB68AC65 for ; Mon, 20 Dec 2021 13:25:33 +0200 (EET) Received: by mail-wm1-f51.google.com with SMTP id g132so3792927wmg.2 for ; Mon, 20 Dec 2021 03:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=OCoLXFnAP9ZSdnob0/JxbYEdqHYNBmwp3lUjGoCKd4k=; b=Ze4GiKnKcYsMwSU6k8ukrLot1wg2xHBOb4gtyLOqCZbkZa3fJFwwsclfktE7ep3rPj WRjmcOXMypoZKsQfjj6CUwIetDcloh9Vhx2rrD2oAqA58Bkv5xDLttweUvOgrnjMGmVM p6oxEGqKbJImiD1CaJE66WTep86qgse6D8beOLue2TuU1uA8axQY8BExqDuRG/lCNaEM /SCXvoz8oZpL9Kft8sTMdGsTOTeNU/YoKeL27wO+cLT+Rzu7CaBfAp3mA5YhXX687Cz+ VQLHYpOAsCDJ7xpn6yOWBXiThPme+JQgf+OL1ALjjPCI0UFLfl8vwIx1ZuaSgnHzHPJR +Nxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=OCoLXFnAP9ZSdnob0/JxbYEdqHYNBmwp3lUjGoCKd4k=; b=0QSCKz2RTB1hEqC4RZl6BoEUnuY8SWAv1fL+k2HgJmHdblOo8VdbIvidVVMyxGgGdo Mtv7y6iWIUoDFIf5QThJUKrD9Fn8mHO8k0/o9PVOtSuKqyOsUCkNI+SEGEUQF6VHCdTd Y9jzAwXPs5Ab6/W4v3DdzTUfAmrBTBscMm5QKWFs4ijCuAoR7zLXLirObtWCXfiBImnZ t1AUsSwUG5OsHmYnA8Xd8O2wLllQal3rRB1EIL78XLKEjbEbiG9deKTfqrSjDlHHwA7D U+IPwB4qPgafAckXScgzsBlW6YYgy40DxC1VFR23+/pe9r0c9lfTK5gvTYhuISjtFKKJ QPQQ== X-Gm-Message-State: AOAM531Vm6QHayvhrRNUTw8LgeHwERPLKuX+dWvaRLTjqFHGfb0niDGs jd+elEQkU9/d9MPmVkdjUY3ufKOwEgu80XIvNHW6uj8PFyc= X-Google-Smtp-Source: ABdhPJz7Bd/d/5B+U3GDtnepUk0WzmBGC1r0qnGW4iF+OZWRDGkA5W5DGJ4rL9dpIuKALilwNeYP0q21VZq9ezVX32E= X-Received: by 2002:a05:600c:4e11:: with SMTP id b17mr8750992wmq.66.1639999532025; Mon, 20 Dec 2021 03:25:32 -0800 (PST) MIME-Version: 1.0 References: <20211220081156.12515-1-mvanb1@gmail.com> In-Reply-To: <20211220081156.12515-1-mvanb1@gmail.com> From: Martijn van Beurden Date: Mon, 20 Dec 2021 12:25:20 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op ma 20 dec. 2021 om 09:12 schreef Martijn van Beurden : > + if (avctx->bits_per_raw_sample == 0) > + avctx->bits_per_raw_sample = 32; This part is wrong. bits_per_raw_sample should not be 0. I assumed that 0 meant 'no different from sample format', but I see now that it means 'unknown'. Apparently this value is not properly set. With this patch, 24-bit audio files are also encoded as 32-bit. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".