From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7A4EF4291F for ; Wed, 6 Apr 2022 07:13:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C9B1F68B1FA; Wed, 6 Apr 2022 10:13:08 +0300 (EEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 82F1968ACAB for ; Wed, 6 Apr 2022 10:13:02 +0300 (EEST) Received: by mail-wr1-f46.google.com with SMTP id r13so1736834wrr.9 for ; Wed, 06 Apr 2022 00:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=OfkkZCx+xulaqEeuknmzpngymK08MQxCvkpu8m3T4Cc=; b=DC1uT2alBE6ozFVd9RuoL/1p8UkPtshWc8OW0SDdjD3gBDzvJHUehIS6q1EdO844fF xUndTejCdvgJ/zNog6t8+lL6ObHV6f5CA3IMAnZGBaELqAYEm5rsav5ZlL7+V0xbl6II 5CdNgJ69utB5p0PPyVbB2NlR4SzkI6FNKxUaP1sf9GK+dfeBiJ8itPSv2dwd54HmhkYx TbPL/QZYHSOMqJ0huhWxr/CyyMtZu3QmN7sGKis65GiIT7BsJkab8d6wgGAf0dPXSTs/ 9s5GNoRv4c7iak8+DLqBHDGkUc1mYkpEMZQZP9hYOY+urmMwYyvAkG+T1KlE2Wq2IyP8 JyJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=OfkkZCx+xulaqEeuknmzpngymK08MQxCvkpu8m3T4Cc=; b=DMV6lpr3emNpRArgLgAG0+wj+5NXGgj2fQJ1RgnS7IvmkE1nhUQpXWfI1oB8KKLWKx AuJ5mqfq+1u+HZ+5Ncf/kH8rExKbHrnttRzmUe9Iwf96MN4EA7ir7oVX+6oAH5uwkkhi jyu8CpOjSTVxbS1Hi+Q295obcrrcArfDqRyo9dUbbV/q4dKAacmxlqdAECeBW2KwNb/m VrKSQBLKbNH92VRtS5SnClJAFep9zOiOyNVpvw2tPH04/iI4EppMtzArcwvucg2CogXz If/eo77vKini4uA4sz6gnpIqQqCk6FHa30DRcifvPE4znb1ehJUlLx696aRFlN7271V+ mSsA== X-Gm-Message-State: AOAM531UnXkexRT/byJlnn53uSFfQB917X5or4CcMlbAG7HX9z5pM5Jp ZOkvqeLxqwv6SLqUX+GrzItuCfML92rnJO6ekEEfybiW2pM= X-Google-Smtp-Source: ABdhPJyixgclDAiIGJfI5IyMP1yn9C8wH4t2uzX5FDWaAb/Q0GUztISOvdr34UcFaSvoWIyUiQEHPRPSbsNxtA/z1aA= X-Received: by 2002:a05:6000:186c:b0:205:3479:ad85 with SMTP id d12-20020a056000186c00b002053479ad85mr5427705wri.54.1649229181552; Wed, 06 Apr 2022 00:13:01 -0700 (PDT) MIME-Version: 1.0 References: <20220405133747.318846-1-mvanb1@gmail.com> In-Reply-To: <20220405133747.318846-1-mvanb1@gmail.com> From: Martijn van Beurden Date: Wed, 6 Apr 2022 09:12:50 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op di 5 apr. 2022 om 15:37 schreef Martijn van Beurden : > > --- > libavcodec/flacdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c > index dd6026f9de..cb32d7cae8 100644 > --- a/libavcodec/flacdec.c > +++ b/libavcodec/flacdec.c > @@ -260,7 +260,7 @@ static int decode_residuals(FLACContext *s, int32_t *decoded, int pred_order) > for (; i < samples; i++) > *decoded++ = get_sbits_long(&gb, tmp); > } else { > - int real_limit = tmp ? (INT_MAX >> tmp) + 2 : INT_MAX; > + int real_limit = (tmp > 1) ? (INT_MAX >> (tmp - 1)) + 2 : INT_MAX; > for (; i < samples; i++) { > int v = get_sr_golomb_flac(&gb, tmp, real_limit, 1); > if (v == 0x80000000){ > -- > 2.30.2 > A file needing this patch to decode properly can be found here: https://github.com/ktmf01/flac-test-files/blob/main/subset/63%20-%20predictor%20overflow%20check%2C%2024-bit.flac Kind regards, Martijn van Beurden _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".