From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 574914024F for ; Thu, 20 Jan 2022 18:59:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5E9AB68B1FE; Thu, 20 Jan 2022 20:59:15 +0200 (EET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 889A368B17D for ; Thu, 20 Jan 2022 20:59:08 +0200 (EET) Received: by mail-wm1-f48.google.com with SMTP id c2so14069453wml.1 for ; Thu, 20 Jan 2022 10:59:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Vtsxu/KjqpqKumpbFuSBBwuvgRiYdumjDsXD7wNA7cs=; b=D257KNugO3BSOFB4X9oGy+iARWdmP9POtwSJnH+V5vOOXgViU5m9JlR2jU5VK6QgYF CRJE6ilhe/LvX0X98gZ0cSifcIk7TBP35IQ3akKD9RXt6vTmp7rrVswbmTTlcfrVQjuZ a3XWAMJ2A0oumnIkBrBCL2fwd06hc9JW1WKZe4W0dflTyns8LkgGHwbTw3L6tYqFAA3h Y4YoFMmdLwAWRE1nKkxgYVFG9fT5nwhZ8VAcj3l2AhlFSAJFmH1+nxWb9RrQmL9PqhXw 2ywRDoLftcTg9irNRE8X1DJa5R/8O1UA8tNbEfbSvkMGUiG5Byr587IKoVcXyNGtvIcX QlDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Vtsxu/KjqpqKumpbFuSBBwuvgRiYdumjDsXD7wNA7cs=; b=u/SKLHxb32vrDlPysGStsmtGujkDWCX7WHuvOunyNkAmMxl1c3c6mXAKZ3Ov/rNGCj hjNJ5A2Vgkv6JKrdvxlcELjf3/2qgk5afHmVMxQkYRFua7n5nvFX6BT1mFDH7WBVaQg3 ZQ9rWpTS5uiRm70VdeSc1lycSoSW7T16jTP5d4exoPJPyLRyQ20aud9rF1xyFrLlrBrY eLVTBmSJ9n9DPFCgq/B5AJdQ9jskfzRtGobRzTjWAhLxFZxw9uG2saj5vRy/3d2vQ8Df XI1A+aq42BdO70CU+xNEbapgITz0zGZE/CkVEv4DsWSwrys82/1ZMZHhNPhBoErnZ2mP VCEA== X-Gm-Message-State: AOAM533Ph7IblPiXTCEKq3pFKPbCGBVhufg9nvfdKmJD0Cdlm/9Xpr8k ofCNc7MvFPK+IUNZVZhc/5m4CDswuA6jBZle8n+6sgwbYZ4= X-Google-Smtp-Source: ABdhPJwQz+YdUV5+punBFoEAIsNkRIqF8A9kl8Qaw7bj7O+nPBzBeKwnQS6eEAZFUD2sovX/EXV3HHCJyGBULNE30O8= X-Received: by 2002:a5d:59a2:: with SMTP id p2mr450627wrr.54.1642705147862; Thu, 20 Jan 2022 10:59:07 -0800 (PST) MIME-Version: 1.0 References: <20220120160506.32698-1-anton@khirnov.net> <20220120160506.32698-3-anton@khirnov.net> In-Reply-To: <20220120160506.32698-3-anton@khirnov.net> From: Martijn van Beurden Date: Thu, 20 Jan 2022 19:58:54 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavc/encode: pick a sane default for bits_per_raw_sample if it's not set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Op do 20 jan. 2022 om 17:05 schreef Anton Khirnov : > Fixes #9563. > --- > libavcodec/encode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index b6f81d1458..44ab81af3f 100644 > --- a/libavcodec/encode.c > +++ b/libavcodec/encode.c > @@ -535,6 +535,9 @@ static int encode_preinit_audio(AVCodecContext *avctx) > return AVERROR(EINVAL); > } > > + if (!avctx->bits_per_raw_sample) > + avctx->bits_per_raw_sample = 8 * > av_get_bytes_per_sample(avctx->sample_fmt); > + > return 0; > } > This creates a new regression: now 24-bit WAV files are converted to 32-bit WavPack files. I think I found the cause of the problem though: the issue is that wavpack uses sample format s32p and 24-bit wav files use s32. Therefore, a aresample filter is auto-inserted to convert s32p to s32, which causes ost->filter->graph->is_meta to be false. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".