Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Parallelc <realparallelc@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_av1: Fix fragment continuation check when OBU_HAS_SIZE_FIELD is set
Date: Mon, 14 Apr 2025 17:57:28 +0800
Message-ID: <CADLiP8XsvRXCYu7Qrbdj+DSVNzA6v6jdJ0dX-OMHD-7fVArprQ@mail.gmail.com> (raw)
In-Reply-To: <d61eecdf-a68e-4a60-9e99-0c25e6d54e04@axis.com>

On Mon, Apr 14, 2025 at 3:13 PM Chris Hodges <Chris.Hodges@axis.com> wrote:
>
> Hi there,
>
> On 4/13/25 17:56, Parallelc wrote:
>
> > When OBU_HAS_SIZE_FIELD is set in the OBU header, frag_obu_size remains 0.
> > The code used !frag_obu_size to check for unexpected fragment continuation,
> > which resulted in incorrect drops. Introduce expect_frag_cont to explicitly
> > track continuation expectation.
>
> Good find! I didn't have sources that kept the OBU size field (just curious,
> what did you use to generate these RTP streams?), and your fix looks good
> to me (although I didn't verify it).
>
> --
> Best regards,
> Chris

Hi Chris,

Thanks for your review!

I'm currently working on adding WHIP and WHEP support to FFmpeg using
libdatachannel
in my personal fork: https://github.com/parallelcc/FFmpeg-WHIP-WHEP

So in my tests, the RTP streams are generated by libdatachannel or
Chrome WebRTC. They
packetize the encoder output directly, without removing the size field
like rtpenc_av1 does.

Best regards,
Parallelc
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-04-14  9:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-13 15:56 Parallelc
2025-04-14  7:13 ` Chris Hodges
2025-04-14  9:57   ` Parallelc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADLiP8XsvRXCYu7Qrbdj+DSVNzA6v6jdJ0dX-OMHD-7fVArprQ@mail.gmail.com \
    --to=realparallelc@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git