From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7455944F26 for ; Mon, 9 Jan 2023 10:57:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 814C168BCA7; Mon, 9 Jan 2023 12:57:09 +0200 (EET) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8DB7368ACF0 for ; Mon, 9 Jan 2023 12:57:03 +0200 (EET) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-476e643d1d5so108028337b3.1 for ; Mon, 09 Jan 2023 02:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=NgBW2ifARRrrW6QauiDi+QcahACB8sPP8gDRVIMyngA=; b=DkQ8z3FwrHZ1Jj/jAEWZjssucf+Jbb4xNDlqkgg0ToZuli/lcwGxDBZ9vNIrp7ztQv 6euBjAZlW245DE7Y/CsfeD9I3RD/QLGxI0c0vQostFAP8oXPjgyg3I0Eb1Cr/NL2ZNcJ 2DP0uoOABLjsjnywp0s4FUlBmAjN3C8kOVynn9y9Xu93ZSKG0JrD/pkgIWCUHFjcvA95 akPiTq/ny/zgcjW70EOwXptqQpH39t8/b+naRCX7Ke0pOb723Z/C+KXU5AFA8+wUQXH6 B80XxEeH97mn9zJVpa1/ztFQjWZJtkB/cHjLRGHhnGYs6+UePm3hhv4CGlOaiEB7r0Kw XQNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NgBW2ifARRrrW6QauiDi+QcahACB8sPP8gDRVIMyngA=; b=ZJYZI2RL80kS0wpB8FjEu6izwkQGfDRl0pfWIYmYXRsBr2Y6+Y3a151XII+Qsm4Jir YdW/64nvYl5DSXFWm9cKeHKIQOfhX3mow2PiLZEtTGKKxm5EgLlPq+kOX7tEFFdIRkjU F/WlFGL8hux/NLzVqSvKoC6jSeHYpb2B92QULNTkffKpU9oD7pk3pQgiQwvm40oEE6ig 0TDZDzM0Jv5T9ttZ4RLw201FySgRUFPQxSKKou7NlTvj0h74zslSwUO8rnXPOXxM1v2A rfJksq5rZBQStbm6cYY2VR+nivR2z79GAkPvGChCkl6h0YQql4askdkp9oxMSE26tzim s/1A== X-Gm-Message-State: AFqh2kqBedoDLA2UgKBLQWnZxVa3DOXaHz0cs/z616wDxZGb2WP7avKE NnDDPBeb3PyXN0uV0fyVqQ/ZrvS1NV7yG2bEm6O9ZwbQszA= X-Google-Smtp-Source: AMrXdXsvaXTDOMdjfL4xl53vO74LnRvnf4HrFqLUi7izsQ+u9b2s08RlkvxXDkELzPyB4FIlKnmFD7+a4RPIbC4iW6U= X-Received: by 2002:a81:e56:0:b0:46d:f613:f2a6 with SMTP id 83-20020a810e56000000b0046df613f2a6mr645917ywo.52.1673261821811; Mon, 09 Jan 2023 02:57:01 -0800 (PST) MIME-Version: 1.0 References: <20230108150622.15075-1-stanislav.ionascu@gmail.com> In-Reply-To: From: Stan I Date: Mon, 9 Jan 2023 10:56:51 +0000 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/dvd: new dvd:// protocol for reading dvd folder/images X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thanks for looking into this. On Mon, Jan 9, 2023 at 9:13 AM Nicolas George wrote: > > Stanislav Ionascu (12023-01-08): > > dvd:// protocol uses libdvdread for opening folders and/or disc-images, > > it then either identifies the longest title-set, or uses the title-set > > parameter. > > > > After opening the dvd, it will read and output all VOBs, in sequence > > defined by the program-chain. > > Thanks for the patch. The reason there was no DVD support in ffmpeg > until now is that it is not as straightforward as it seems. > > Your patch is missing documentation, including documentation about its > limitations. Please clarify various points: > > - VOBs contain not only the movie but also menu data: will it be mixed > along with the movie or skipped? The protocol, when opening the DVD folder or image, will read the VMG and VTS info to identify the longest title. If identification was incorrect, the title can be overridden via command-line parameters. But most of the time it will be the main-movie. The VOBs that are read via libdvdread belong to that video title set, so menu VOBs should be skipped. > > - Are the timestamps monotonous over a whole title? Since this is a protocol, it doesn't really do much about demuxing and the timestamps, so it depends on the data in VOBs and the probed demuxer (mpeg). From the ffmpeg perspective, this is a continuous single concatenated VOB, similar to what the "concat" demuxer generates from split-VOBs, so generating timestamps may be required when muxing into a format that requires them, like matroska. > > - Does ffmpeg correctly detect all the subtitles streams? Yes, ffmpeg either discovers them later in the stream, or with adequate analyzeduration/probesize during probing. > > - Does ffmpeg correctly detect the language of audio and subtitles > streams? > > - Are chapters detected? As this is protocol, it only provides the data that is stored in the VOBs. Libdvdread has the language and chapter information, but I don't know how to attach it to the stream without having to use a slave mpeg-demuxer. For the sample files I've used : 1. streams.videolan.org/samples/MPEG-VOB/menus\ DVD/free.iso 2. www.deniscarl.com/dvdtest/videotest.iso.bz2 3. dvdauthor-built disc from generated av streams > > Regards, > > -- > Nicolas George Thanks! Stan. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".