From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B375443288 for ; Mon, 24 Oct 2022 14:24:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 882A968BC41; Mon, 24 Oct 2022 17:24:19 +0300 (EEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A25A068A302 for ; Mon, 24 Oct 2022 17:24:12 +0300 (EEST) Received: by mail-pf1-f169.google.com with SMTP id i3so9059895pfc.11 for ; Mon, 24 Oct 2022 07:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spin-digital-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=HZ2rUTnP1i/Q2h0hQYXELcO7PcI37js5wINSH5Vvys8=; b=tTyyLAbJqA5+r7TVo2SSAADB5ahP3386zcaiPnp0D3XcdjtmZTgeSSR8s21Z5E1MUw F5mVq2hU8wsjTnfOy7Ep6iormTeJlV/K5rQ36IbqiLK0BNDuuDhCeWPPFOdHXy8l3MLA 8MxgCHAxaPCq5B29Cglkgv6F/KxX0FzMg5SndapfuZ438Bzm6cTRaGABs5Qk1mROHlLj Rag4/mBIjCAhPkAgRqL3Vw9Iog5F1DKkOhs47E1cLiuNmbAqcyfV6fKmRqlRPU06+EHQ vaStEeUFifbdQ9K65RBQ3iYZLYtqlOsCTkbj115ztxJnUf1wbk5dUA0nFxSJT44pbQjS dOMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HZ2rUTnP1i/Q2h0hQYXELcO7PcI37js5wINSH5Vvys8=; b=if1TfBgNqNsOq0GKMVnfWHMK6EIZ8qb83Ee00nHbxHoAKwmn38YndIfJFhPOs7J6WG PnkbdNLG5HlBygmtgVDXlOsp3zuCgTFZXkFy6u6D2QHkUbtsDUm0nsdAjqcBGlz6Xhe/ +JwTP2K3bIYryt/g1uhy9NDf6pKwa8s8dDUfYZ/8oXeXYoGYraRXRX1ANLekHTG4N3Mg n8/j6vCOOkFK0jd5XLHDxhTTOz47D74i1cR9wpXQMS4RkAzB3BNFd1SgSw93hsAJ5DzY bxmiM1gKDPPi4M6iun8ciRdgbTWVd3LjMcJ0MfAK8hgrZOSxD+JBzPytfRviLcyLmair dmRQ== X-Gm-Message-State: ACrzQf1Zh+f5WLvYIrhxd5Yd/hLrMPUNqsLdWqKHWMRfmCbJ/zuGn45d 3WDB0CwqyqpnnicqWtJzCHlloaJNI6XIOLOLhoY5JMcmAIvaMg== X-Google-Smtp-Source: AMsMyM4PLDCiE66cuQIEv7zqOWpTjKH9zxh2B6RRtWz7Y/CSqHKJvU2a7EOhmDquXFW8erw08c0SsyQUpe65SkaaV3I= X-Received: by 2002:a05:6a00:2289:b0:56b:b912:4800 with SMTP id f9-20020a056a00228900b0056bb9124800mr7509108pfe.62.1666621450486; Mon, 24 Oct 2022 07:24:10 -0700 (PDT) MIME-Version: 1.0 References: <20221019072508.23460-1-thomas.ff@spin-digital.com> <20221019072508.23460-4-thomas.ff@spin-digital.com> In-Reply-To: From: Thomas Siedel Date: Mon, 24 Oct 2022 16:23:58 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v1 03/11] avcodec: enable cbs for H266/VVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 20 Oct 2022 at 01:07, James Almer wrote: > On 10/19/2022 4:25 AM, thomas.ff@spin-digital.com wrote: > > From: Thomas Siedel > > > > Add ff_cbs_type_h266 to cbs types tables and AV_CODEC_ID_H266 to cbs > codec ids. > > Change CBS_MAX_UNIT_TYPES to 8 as VVC implements 8 different slice types > > > > Signed-off-by: Thomas Siedel > > --- > > libavcodec/Makefile | 1 + > > libavcodec/cbs.c | 6 ++++++ > > libavcodec/cbs_internal.h | 3 ++- > > 3 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > > index c7dc5da0f9..b3fcf173e9 100644 > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -76,6 +76,7 @@ OBJS-$(CONFIG_CBS) += cbs.o > cbs_bsf.o > > OBJS-$(CONFIG_CBS_AV1) += cbs_av1.o > > OBJS-$(CONFIG_CBS_H264) += cbs_h2645.o cbs_sei.o > h2645_parse.o > > OBJS-$(CONFIG_CBS_H265) += cbs_h2645.o cbs_sei.o > h2645_parse.o > > +OBJS-$(CONFIG_CBS_H266) += cbs_h2645.o cbs_sei.o > h2645_parse.o > > CONFIG_CBS_H266 is undefined. You need to add cbs_h266 to configure here > instead of in patch 4/11, even if no module selects it just yet. > > Also, this patch should be squashed with patch 2/11. > Thank you for your feedback, I did not notice this before. I now changed it as you suggested and also combined patches 2 and 3. The changes are included in the new version of the patch set that I just submitted. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".