Re: [FFmpeg-devel] [PATCH v1 03/11] avcodec: enable cbs for H266/VVC

[Thomas Siedel <thomas.ff@spin-digital.com>]

On Thu, 20 Oct 2022 at 01:07, James Almer <jamrial@gmail.com> wrote:

> On 10/19/2022 4:25 AM, thomas.ff@spin-digital.com wrote:
> > From: Thomas Siedel <thomas.ff@spin-digital.com>
> >
> > Add ff_cbs_type_h266 to cbs types tables and AV_CODEC_ID_H266 to cbs
> codec ids.
> > Change CBS_MAX_UNIT_TYPES to 8 as VVC implements 8 different slice types
> >
> > Signed-off-by: Thomas Siedel <thomas.ff@spin-digital.com>
> > ---
> >   libavcodec/Makefile       | 1 +
> >   libavcodec/cbs.c          | 6 ++++++
> >   libavcodec/cbs_internal.h | 3 ++-
> >   3 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> > index c7dc5da0f9..b3fcf173e9 100644
> > --- a/libavcodec/Makefile
> > +++ b/libavcodec/Makefile
> > @@ -76,6 +76,7 @@ OBJS-$(CONFIG_CBS)                     += cbs.o
> cbs_bsf.o
> >   OBJS-$(CONFIG_CBS_AV1)                 += cbs_av1.o
> >   OBJS-$(CONFIG_CBS_H264)                += cbs_h2645.o cbs_sei.o
> h2645_parse.o
> >   OBJS-$(CONFIG_CBS_H265)                += cbs_h2645.o cbs_sei.o
> h2645_parse.o
> > +OBJS-$(CONFIG_CBS_H266)                += cbs_h2645.o cbs_sei.o
> h2645_parse.o
>
> CONFIG_CBS_H266 is undefined. You need to add cbs_h266 to configure here
> instead of in patch 4/11, even if no module selects it just yet.
>
> Also, this patch should be squashed with patch 2/11.
>

Thank you for your feedback, I did not notice this before. I now changed it
as you suggested and also combined patches 2 and 3.
The changes are included in the new version of the patch set that I just
submitted.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".